Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-29183: Enable crun as runtime only if missing #937

Merged
merged 3 commits into from Feb 9, 2024
Merged

OCPBUGS-29183: Enable crun as runtime only if missing #937

merged 3 commits into from Feb 9, 2024

Conversation

mrniranjan
Copy link
Contributor

In certain situation crun is configured prior to running the tests causing the test to fails.

In this PR we check if crun is already enabled , in which case we skip the configuration part.

Enable crun as runtime only if missing
f2b371f 
In certain situation crun is configured prior to running
the tests causing the test to fails.

In this PR we check if crun is already enabled , in which case
we skip the configuration part.

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
Tal-or
Tal-or reviewed Feb 7, 2024
View reviewed changes
test/e2e/performanceprofile/functests/2_performance_update/updating_profile.go
@@ -1190,26 +1190,26 @@ var _ = Describe("[rfe_id:28761][performance] Updating parameters in performance
By("checking if ContainerRuntimeConfig object already exists")
ctrcfg, err := getContainerRuntimeConfigFrom(context.TODO(), profile, mcp)
Expect(err).ToNot(HaveOccurred(), "failed to get ContainerRuntimeConfig from profile %q mcp %q", profile.Name, mcp.Name)
if ctrcfg == nil {
Copy link
Contributor

@Tal-or Tal-or Feb 7, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set the When in line 1180 to Ordered and add this code in BeforeAll() closure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in the latest commit

@mrniranjan mrniranjan changed the title Enable crun as runtime only if missing OCPBUGS-29183: Enable crun as runtime only if missing Feb 7, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 7, 2024
@openshift-ci-robot
Copy link
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-29183, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In certain situation crun is configured prior to running the tests causing the test to fails.

In this PR we check if crun is already enabled , in which case we skip the configuration part.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mrniranjan
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 7, 2024
@openshift-ci-robot
Copy link
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-29183, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 7, 2024
Niranjan M.R added 2 commits February 7, 2024 19:39
Moving crun setup code to BeforeAll and making tests ordered
1fc29a5 
Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
make the spec ordered
ae4882d 
Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@Tal-or
Copy link
Contributor

Tal-or commented Feb 7, 2024

/lgtm
Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
ffromani
ffromani reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ac0f8bd and 2 for PR HEAD ae4882d in total

@mrniranjan
Copy link
Contributor Author

/test e2e-hypershift

2 similar comments
@mrniranjan
Copy link
Contributor Author

/test e2e-hypershift

@mrniranjan
Copy link
Contributor Author

/test e2e-hypershift

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3091b8c into openshift:master Feb 9, 2024
15 checks passed
@openshift-ci-robot
Copy link
Contributor

@mrniranjan: Jira Issue OCPBUGS-29183: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29183 has been moved to the MODIFIED state.

In response to this:

In certain situation crun is configured prior to running the tests causing the test to fails.

In this PR we check if crun is already enabled , in which case we skip the configuration part.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202402100540.p0.g3091b8c.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

@mrniranjan
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@mrniranjan: new pull request created: #945

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 10, 2024
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@Tal-or Tal-or Tal-or left review comments

@jlojosnegros jlojosnegros Awaiting requested review from jlojosnegros

Assignees

@Tal-or Tal-or

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mrniranjan @openshift-ci-robot @Tal-or @openshift-bot @openshift-cherrypick-robot @ffromani