NO-JIRA: Remove RELEASE_VERSION from test-upstream-tuned.sh #969
Conversation
Starting with PR858, we can no longer use a random RELEASE_VERSION to trigger daemonset/operand updates. In the context of testing upstream TuneD this is causes an issue. Not changing RELEASE_VERSION at all is a simple fix, because we are also adjusting CLUSTER_NODE_TUNED_IMAGE and that will cause a daemonset/operand update.
jmencak
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jmencak: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
Tested with the latest TuneD 2.22.1 which will be the next FDP release. |
|
/retest |
|
Infra issues |
|
/retest |
|
There's no way this can break |
|
/override ci/prow/e2e-gcp-pao |
|
/retest |
|
@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm holding to let other reviewers chime in, feel free to remove anytime |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, MarSik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-gcp-pao-updating-profile |
|
@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao-updating-profile In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403081048.p0.gf9c912b.assembly.stream.el9 for distgit cluster-node-tuning-operator. |
Starting with PR858, we can no longer use a random RELEASE_VERSION to trigger daemonset/operand updates. In the context of testing upstream TuneD this is causes an issue. Not changing RELEASE_VERSION at all is a simple fix, because we are also adjusting CLUSTER_NODE_TUNED_IMAGE and that will cause a daemonset/operand update. Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>
Starting with PR858, we can no longer use a random
RELEASE_VERSIONto trigger daemonset/operand updates. In the context of testing upstream TuneD this is causes an issue. Not changingRELEASE_VERSIONat all is a simple fix, because we are also adjustingCLUSTER_NODE_TUNED_IMAGEand that will cause a daemonset/operand update.