Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: e2e: perf-prof: increase logging for debugging #974

Merged
merged 1 commit into from Mar 6, 2024

Conversation

shajmakh
Copy link
Contributor

@shajmakh shajmakh commented Mar 1, 2024

One of the tests is failing in u/s and printing out the pod events is not enough for debugging.
Add another condition to skip the test if the requested cpus is greater than what the node can provide; and log a bit more info about the pod to be created.

One of the tests is failing in u/s and printing out the pod events is
not enough for debugging.
Add another condition to skip the test if the requested cpus is greater than what
the node can provide; and log a bit more info about the pod to be
created.

Signed-off-by: Shereen Haj <shajmakh@redhat.com>
@jlojosnegros
Copy link
Contributor

/lgtm

Copy link
Contributor

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@yanirq
Copy link
Contributor

yanirq commented Mar 2, 2024

/retest-required

1 similar comment
@yanirq
Copy link
Contributor

yanirq commented Mar 3, 2024

/retest-required

@yanirq
Copy link
Contributor

yanirq commented Mar 3, 2024

@shajmakh if this need a cherry pick - please open a bug and add to the PR title (otherwise add the NO-JIRA title)

@ffromani
Copy link
Contributor

ffromani commented Mar 4, 2024

/retest-required

@shajmakh
Copy link
Contributor Author

shajmakh commented Mar 4, 2024

/retitle NO-JIRA: e2e: perf-prof: increase logging for debugging

@openshift-ci openshift-ci bot changed the title e2e: perf-prof: increase logging for debugging NO-JIRA: e2e: perf-prof: increase logging for debugging Mar 4, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 4, 2024
@openshift-ci-robot
Copy link
Contributor

@shajmakh: This pull request explicitly references no jira issue.

In response to this:

One of the tests is failing in u/s and printing out the pod events is not enough for debugging.
Add another condition to skip the test if the requested cpus is greater than what the node can provide; and log a bit more info about the pod to be created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 28bebe3 and 2 for PR HEAD 46e0e2c in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 829b837 and 1 for PR HEAD 46e0e2c in total

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@shajmakh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e4995df into openshift:master Mar 6, 2024
15 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403061047.p0.ge4995df.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Tal-or pushed a commit to Tal-or/cluster-node-tuning-operator that referenced this pull request Apr 1, 2024
One of the tests is failing in u/s and printing out the pod events is
not enough for debugging.
Add another condition to skip the test if the requested cpus is greater than what
the node can provide; and log a bit more info about the pod to be
created.

Signed-off-by: Shereen Haj <shajmakh@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants