Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-26400: scheduler plugin: ignore IRQs #976

Merged
merged 1 commit into from Mar 6, 2024
Merged

OCPBUGS-26400: scheduler plugin: ignore IRQs #976

merged 1 commit into from Mar 6, 2024

Conversation

yanirq
Copy link
Contributor

@yanirq yanirq commented Mar 3, 2024 •
edited

Set tuned scheduler plugin not to change any IRQ affinities. This overrides the default(true) which is set via
the parent cpu partitioning profile.

Utilized redhat-performance/tuned#595

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 3, 2024
@openshift-ci-robot
Copy link
Contributor

@yanirq: This pull request references Jira Issue OCPBUGS-26400, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @shajmakh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Set tuned scheduler plugin not to change any IRQ affinities. This overrides the default(true) which is set via
the parent cpu partitioning profiles.

Utilized redhat-performance/tuned#595

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2024
@yanirq
OCPBUGS-26400: scheduler plugin: ignore IRQs
4d71ddb 
Set tuned scheduler plugin not to change any IRQ affinities.
This overrides the default(true) which is set via
the parent cpu partitioning profiles.

Signed-off-by: Yanir Quinn <yquinn@redhat.com>
@yanirq
Copy link
Contributor Author

yanirq commented Mar 3, 2024

/cc @MarSik

@openshift-ci openshift-ci bot requested a review from MarSik March 3, 2024 14:28
@openshift-ci-robot
Copy link
Contributor

@yanirq: This pull request references Jira Issue OCPBUGS-26400, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @shajmakh

In response to this:

Set tuned scheduler plugin not to change any IRQ affinities. This overrides the default(true) which is set via
the parent cpu partitioning profile.

Utilized redhat-performance/tuned#595

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yanirq
Copy link
Contributor Author

yanirq commented Mar 3, 2024

/retest

MarSik
MarSik approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 28bebe3 and 2 for PR HEAD 4d71ddb in total

@yanirq
Copy link
Contributor Author

yanirq commented Mar 5, 2024

/retest

@yanirq
Copy link
Contributor Author

yanirq commented Mar 5, 2024

/retest-required

1 similar comment
@yanirq
Copy link
Contributor Author

yanirq commented Mar 5, 2024

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 829b837 and 1 for PR HEAD 4d71ddb in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@yanirq: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fd8262f into openshift:master Mar 6, 2024
15 checks passed
@openshift-ci-robot
Copy link
Contributor

@yanirq: Jira Issue OCPBUGS-26400: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26400 has been moved to the MODIFIED state.

In response to this:

Set tuned scheduler plugin not to change any IRQ affinities. This overrides the default(true) which is set via
the parent cpu partitioning profile.

Utilized redhat-performance/tuned#595

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yanirq
Copy link
Contributor Author

yanirq commented Mar 6, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@yanirq: #976 failed to apply on top of branch "release-4.15":

Applying: OCPBUGS-26400: scheduler plugin: ignore IRQs
Using index info to reconstruct a base tree...
M	assets/performanceprofile/tuned/openshift-node-performance
A	test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-ctrcfg/openshift-bootstrap-master_tuned.yaml
A	test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-ctrcfg/openshift-bootstrap-worker_tuned.yaml
M	test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-mcp/openshift-bootstrap-master_tuned.yaml
M	test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-mcp/openshift-bootstrap-worker_tuned.yaml
M	test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/no-mcp/openshift-bootstrap-master_tuned.yaml
M	test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/no-mcp/openshift-bootstrap-worker_tuned.yaml
A	test/e2e/performanceprofile/testdata/render-expected-output/default/cpuFrequency/manual_tuned.yaml
M	test/e2e/performanceprofile/testdata/render-expected-output/default/manual_tuned.yaml
A	test/e2e/performanceprofile/testdata/render-expected-output/no-ref/manual_tuned.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/default/manual_tuned.yaml
CONFLICT (modify/delete): test/e2e/performanceprofile/testdata/render-expected-output/default/cpuFrequency/manual_tuned.yaml deleted in HEAD and modified in OCPBUGS-26400: scheduler plugin: ignore IRQs. Version OCPBUGS-26400: scheduler plugin: ignore IRQs of test/e2e/performanceprofile/testdata/render-expected-output/default/cpuFrequency/manual_tuned.yaml left in tree.
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/no-mcp/openshift-bootstrap-worker_tuned.yaml
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/no-mcp/openshift-bootstrap-master_tuned.yaml
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-mcp/openshift-bootstrap-worker_tuned.yaml
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-mcp/openshift-bootstrap-master_tuned.yaml
CONFLICT (modify/delete): test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-ctrcfg/openshift-bootstrap-worker_tuned.yaml deleted in HEAD and modified in OCPBUGS-26400: scheduler plugin: ignore IRQs. Version OCPBUGS-26400: scheduler plugin: ignore IRQs of test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-ctrcfg/openshift-bootstrap-worker_tuned.yaml left in tree.
CONFLICT (modify/delete): test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-ctrcfg/openshift-bootstrap-master_tuned.yaml deleted in HEAD and modified in OCPBUGS-26400: scheduler plugin: ignore IRQs. Version OCPBUGS-26400: scheduler plugin: ignore IRQs of test/e2e/performanceprofile/testdata/render-expected-output/bootstrap/extra-ctrcfg/openshift-bootstrap-master_tuned.yaml left in tree.
Auto-merging assets/performanceprofile/tuned/openshift-node-performance
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-26400: scheduler plugin: ignore IRQs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403060709.p0.gfd8262f.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

@yanirq yanirq mentioned this pull request Mar 6, 2024
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-03-06-174829

Tal-or pushed a commit to Tal-or/cluster-node-tuning-operator that referenced this pull request Apr 1, 2024
@yanirq @Tal-or
OCPBUGS-26400: scheduler plugin: ignore IRQs (openshift#976)
8918722 
Set tuned scheduler plugin not to change any IRQ affinities.
This overrides the default(true) which is set via
the parent cpu partitioning profiles.

Signed-off-by: Yanir Quinn <yquinn@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarSik MarSik MarSik approved these changes

@shajmakh shajmakh Awaiting requested review from shajmakh

@ffromani ffromani Awaiting requested review from ffromani

@kpouget kpouget Awaiting requested review from kpouget

Assignees

@MarSik MarSik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yanirq @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot @openshift-merge-robot @MarSik