Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Add sync for rendering extra ctrcfgs #980

Merged
merged 1 commit into from Mar 23, 2024

Conversation

yanirq
Copy link
Contributor

@yanirq yanirq commented Mar 4, 2024

Add missing sync for rendering extra ctrcfgs under the render-sync target

This was missing from #972

(no backport needed)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 4, 2024
@openshift-ci-robot
Copy link
Contributor

@yanirq: This pull request explicitly references no jira issue.

In response to this:

Add missing sync for rendering extra ctrcfgs under the render-sync target

This was missing from #972

(no backport needed)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@yanirq
Copy link
Contributor Author

yanirq commented Mar 11, 2024

/retest

Signed-off-by: Yanir Quinn <yquinn@redhat.com>
@yanirq
Copy link
Contributor Author

yanirq commented Mar 12, 2024

/retest

@yanirq
Copy link
Contributor Author

yanirq commented Mar 16, 2024

/retest

@Tal-or
Copy link
Contributor

Tal-or commented Mar 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@yanirq
Copy link
Contributor Author

yanirq commented Mar 19, 2024

/label acknowledge-critical-fixes-only
no risk, local tool change only.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 19, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f5aa533 and 2 for PR HEAD 564ab15 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4930aa0 and 1 for PR HEAD 564ab15 in total

Copy link
Contributor

openshift-ci bot commented Mar 23, 2024

@yanirq: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1e220ba into openshift:master Mar 23, 2024
16 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403230715.p0.g1e220ba.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Tal-or pushed a commit to Tal-or/cluster-node-tuning-operator that referenced this pull request Apr 1, 2024
Signed-off-by: Yanir Quinn <yquinn@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants