Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depend on cluster-config-operator #139

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Feb 7, 2019

Depend on cluster-config-operator to sync configs and CRDs.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2019
@@ -146,7 +146,7 @@ func TestProgressingCondition(t *testing.T) {
apiregistrationv1Client: kubeAggregatorClient.ApiregistrationV1(),
}

syncOpenShiftAPIServer_v311_00_to_latest(operator, operatorConfig)
_, _ = syncOpenShiftAPIServer_v311_00_to_latest(operator, operatorConfig)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't normally do this.

@deads2k
Copy link
Contributor

deads2k commented Feb 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@deads2k
Copy link
Contributor

deads2k commented Feb 7, 2019

terraform
/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit cdfef7b into openshift:master Feb 7, 2019
@sanchezl sanchezl deleted the depend_on_ccop branch March 19, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants