-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifests: move role and rolebinding needed by prometheus servicemonitor #224
Conversation
/lgtm |
/assign @openshift/openshift-team-master-maintainers |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
bbd081c
to
5058b33
Compare
5058b33
to
754ac8b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: paulfantom, s-urbaniak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ping @openshift/openshift-team-master-maintainers |
since these are in the managed namespace, they should be managed by our operator, not the CVO. @sanchezl please guide them to the right spot. |
|
/lgtm cancel |
754ac8b
to
253db56
Compare
253db56
to
2e7be4c
Compare
ping @paulfantom re: #224 (comment) |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
@paulfantom: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
@paulfantom ping, can you please verify if this is still relevant? |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We forgot to move Role and RoleBinding when moving ServiceMonitor out of cluster monitoring operator.
Follow-up to #208
Relates to openshift/cluster-monitoring-operator#438
/cc @s-urbaniak