Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump(*): library-go for fileobserver fixes and switch to go.mod #257

Merged
merged 3 commits into from Dec 5, 2019
Merged

bump(*): library-go for fileobserver fixes and switch to go.mod #257

merged 3 commits into from Dec 5, 2019

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Nov 12, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2019
@mfojtik
Copy link
Member Author

mfojtik commented Nov 12, 2019

/override ci/prow/verify-deps

I will get this removed soon

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/verify-deps

In response to this:

/override ci/prow/verify-deps

I will get this removed soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member Author

mfojtik commented Nov 13, 2019

/test ci/prow/e2e-aws

@mfojtik
Copy link
Member Author

mfojtik commented Nov 13, 2019

/retest

@mfojtik
Copy link
Member Author

mfojtik commented Nov 13, 2019

verify-deps removal: openshift/release#5887

@mfojtik
Copy link
Member Author

mfojtik commented Nov 13, 2019

flake: https://bugzilla.redhat.com/show_bug.cgi?id=1772189

/retest

@deads2k
Copy link
Contributor

deads2k commented Nov 13, 2019 •
edited

all about some go mod, eh?

/approve

@mfojtik
Copy link
Member Author

mfojtik commented Nov 14, 2019

/retest

soltysh
soltysh approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Member Author

mfojtik commented Nov 14, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2019
@mfojtik
Copy link
Member Author

mfojtik commented Nov 18, 2019

/retest

1 similar comment
@mfojtik
Copy link
Member Author

mfojtik commented Nov 19, 2019

/retest

@mfojtik
Copy link
Member Author

mfojtik commented Nov 19, 2019

/override ci/prow/verify-deps

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/verify-deps

In response to this:

/override ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member Author

mfojtik commented Nov 20, 2019

/retest

2 similar comments
@mfojtik
Copy link
Member Author

mfojtik commented Nov 20, 2019

/retest

@mfojtik
Copy link
Member Author

mfojtik commented Nov 20, 2019

/retest

@mfojtik
Copy link
Member Author

mfojtik commented Nov 22, 2019 •
edited

@soltysh

fail [github.com/openshift/origin/test/extended/cli/explain.go:341]: Unexpected error:
   <*errors.errorString | 0xc004852960>: {
       s: "oc explain [\"openshiftapiservers\" \"--api-version=operator.openshift.io/v1\"] result {KIND:     OpenShiftAPIServer\nVERSION:  operator.openshift.io/v1\n\nDESCRIPTION:\n     <empty>} doesn't match pattern {(?s)DESCRIPTION:.*FIELDS:.*spec.*<.*>.*(status.*<.*>.*)?}",
   }
   oc explain ["openshiftapiservers" "--api-version=operator.openshift.io/v1"] result {KIND:     OpenShiftAPIServer
   VERSION:  operator.openshift.io/v1
   
   DESCRIPTION:
        <empty>} doesn't match pattern {(?s)DESCRIPTION:.*FIELDS:.*spec.*<.*>.*(status.*<.*>.*)?}
occurred

this is failing pretty consistently in this PR, any clues?

@mfojtik
Copy link
Member Author

mfojtik commented Nov 27, 2019

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@mfojtik
Copy link
Member Author

mfojtik commented Nov 28, 2019

/override ci/prow/verify-deps

@mfojtik mfojtik added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/verify-deps

In response to this:

/override ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@mfojtik
Copy link
Member Author

mfojtik commented Dec 5, 2019

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2019 •
edited

@mfojtik: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/verify-deps 8facd45 link /test verify-deps

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link
Member Author

mfojtik commented Dec 5, 2019

/override ci/prow/verify-deps

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/verify-deps

In response to this:

/override ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@mfojtik
Copy link
Member Author

mfojtik commented Dec 5, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik, p0lyn0mial, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 14ddf4d into openshift:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mfojtik @openshift-ci-robot @deads2k @openshift-bot @p0lyn0mial @soltysh @openshift-merge-robot