Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1771986: encryption: backup/restore support + speedup + fixes #267

Merged
merged 1 commit into from Nov 28, 2019
Merged

Bug 1771986: encryption: backup/restore support + speedup + fixes #267

merged 1 commit into from Nov 28, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Nov 27, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 27, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@sttts sttts force-pushed the sttts-encryption-backup-last-key branch from 7a5c6f9 to 4f6a388 Compare November 27, 2019 22:44
@sttts sttts changed the title bump(library-go): encryption: keep last read key after migration for easier backup/restore Bug 1771986: bump(library-go): encryption: keep last read key after migration for easier backup/restore Nov 28, 2019
@openshift-ci-robot
Copy link

@sttts: This pull request references Bugzilla bug 1771986, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1771986: bump(library-go): encryption: keep last read key after migration for easier backup/restore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 28, 2019
@sttts sttts changed the title Bug 1771986: bump(library-go): encryption: keep last read key after migration for easier backup/restore Bug 1771986: encryption: backup/restore support + speedup + fixes Nov 28, 2019
@sttts sttts force-pushed the sttts-encryption-backup-last-key branch from 4f6a388 to 42856dc Compare November 28, 2019 14:36
@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@p0lyn0mial
Copy link
Contributor

ci/prow/e2e-aws-operator-encryption-perf

infra related Error: NoSuchBucket: The specified bucket does not exist"

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link
Contributor Author

sttts commented Nov 28, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 301333b into openshift:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@tnozicka tnozicka Awaiting requested review from tnozicka

Assignees

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sttts @openshift-ci-robot @p0lyn0mial @openshift-bot @openshift-merge-robot