create apiservice controller #275
Conversation
|
@deads2k: GitHub didn't allow me to assign the following users: sohankunkerkar. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
size/L
deads2k
force-pushed
the
apiservice-controller
branch
2 times, most recently
from
31d2010
to
3cccf75
Compare
openshift-ci-robot
added
size/XL
|
/retest |
|
|
||
| for _, condition := range apiService.Status.Conditions { | ||
| if condition.Type == apiregistrationv1.Available { | ||
| if condition.Status == apiregistrationv1.ConditionFalse { |
There was a problem hiding this comment.
it could still be ConditionUnknown, shall we check for != ConditionTrue instead?
|
|
||
| // if the apiservices themselves check out ok, try to actually hit the discovery endpoints. We have a history in clusterup | ||
| // of something delaying them. This isn't perfect because of round-robining, but let's see if we get an improvement | ||
| if len(availableConditionMessages) == 0 && c.kubeClient.Discovery().RESTClient() != nil { |
There was a problem hiding this comment.
availableConditionMessages will always be of len 0 here
deads2k
force-pushed
the
apiservice-controller
branch
from
3cccf75
to
5091ddd
Compare
| } | ||
| } | ||
| if !exists { | ||
| coordinates = append(coordinates) |
deads2k
force-pushed
the
apiservice-controller
branch
from
5091ddd
to
c04bbc1
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deads2k
force-pushed
the
apiservice-controller
branch
from
c04bbc1
to
4687403
Compare
|
New changes are detected. LGTM label has been removed. |
Separate the apiservices into a different control loop so we can re-use it for the oauth-apiserver
/assign @p0lyn0mial @sanchezl @sohankunkerkar