Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1798215: Add a new label 'apiserver' to identify the source #307

Merged
merged 1 commit into from Feb 6, 2020
Merged

Bug 1798215: Add a new label 'apiserver' to identify the source #307

merged 1 commit into from Feb 6, 2020

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Feb 2, 2020

Add a new label 'apiserver' to apiserver_current_inflight_requests
metric to identify that the source is openshift apiserver.

The label would say - apiserver:openshift-apiserver

Do the similar for kube-apiserver - apiserver:kube-apiserver

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2020
@tkashem tkashem mentioned this pull request Feb 2, 2020
Merged
@tkashem
Copy link
Contributor Author

tkashem commented Feb 2, 2020

Related PR - openshift/cluster-kube-apiserver-operator#737

@brancz
Copy link

brancz commented Feb 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
brancz
brancz reviewed Feb 3, 2020
View reviewed changes
manifests/0000_90_openshift-apiserver-operator_04_servicemonitor-apiserver.yaml
@@ -51,6 +51,12 @@ spec:
regex: apiserver_admission_step_admission_latencies_seconds_.*
sourceLabels:
- __name__
- action: replace
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as openshift/cluster-kube-apiserver-operator#737 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @brancz

@sttts
Copy link
Contributor

sttts commented Feb 3, 2020

/retest
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@brancz
Copy link

brancz commented Feb 3, 2020

Sorry I lgtm’d too quickly earlier, my comment does need to be addressed.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2020
@tkashem
Add a new label 'apiserver' to identify the source
452d8d3 
Add a new label 'apiserver' to apiserver_current_inflight_requests
metric to identify that the source is openshift apiserver.

The label would say - apiserver:openshift-apiserver

Do the similar for kube-apiserver - apiserver:kube-apiserver
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@tkashem tkashem mentioned this pull request Feb 3, 2020
Closed
@tkashem
Copy link
Contributor Author

tkashem commented Feb 3, 2020

Sorry I lgtm’d too quickly earlier, my comment does need to be addressed.

@brancz I addressed your feedback, please review.

@tkashem
Copy link
Contributor Author

tkashem commented Feb 4, 2020

/retest

@tkashem tkashem mentioned this pull request Feb 4, 2020
Merged
@tkashem tkashem changed the title Add a new label 'apiserver' to identify the source Bug 1798215: Add a new label 'apiserver' to identify the source Feb 4, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 4, 2020
@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1798215, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1798215: Add a new label 'apiserver' to identify the source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brancz
Copy link

brancz commented Feb 5, 2020

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 5, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tkashem
Copy link
Contributor Author

tkashem commented Feb 5, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tkashem
Copy link
Contributor Author

tkashem commented Feb 5, 2020

/retest

1 similar comment
@tkashem
Copy link
Contributor Author

tkashem commented Feb 5, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c0c8f5e into openshift:master Feb 6, 2020
@openshift-ci-robot
Copy link

@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1798215 has been moved to the MODIFIED state.

In response to this:

Bug 1798215: Add a new label 'apiserver' to identify the source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz left review comments

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tkashem @brancz @sttts @openshift-bot @openshift-ci-robot @openshift-merge-robot