Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waits for requestheader-client-ca-file in extension-apiserver-authentication before rolling out a new version #327

Merged
merged 1 commit into from Mar 2, 2020
Merged

waits for requestheader-client-ca-file in extension-apiserver-authentication before rolling out a new version #327

merged 1 commit into from Mar 2, 2020

Conversation

p0lyn0mial
Copy link
Contributor

No description provided.

@p0lyn0mial
Copy link
Contributor Author

/assign @sttts

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2020
@p0lyn0mial
Copy link
Contributor Author

I didn't validate against master because the bundle and the tools I got were for 4.3 version which was successfully validated with #326

@p0lyn0mial
Copy link
Contributor Author

/cherrypick release-4.4

@openshift-cherrypick-robot
Copy link

@p0lyn0mial: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Contributor Author

/retest

sttts
sttts reviewed Mar 2, 2020
View reviewed changes
pkg/operator/workloadcontroller/workload_controller.go Outdated
if apierrors.IsNotFound(err) {
klog.Infof("Waiting for %q configmap in %q namespace to be available", "extension-apiserver-authentication", metav1.NamespaceSystem)
return nil
}
if err != nil {
return err
}

if len(authConfigMap.Data["requestheader-client-ca-file"]) == 0 {
klog.Infof("missing requestheader-client-ca-file filed in %q configmap", "extension-apiserver-authentication")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.V(2)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better: waiting for requestheader-client-ca-file in ... to be populated

@p0lyn0mial p0lyn0mial force-pushed the check-requestheader-client-ca-file branch from 451e4c1 to 765beda Compare March 2, 2020 10:24
@sttts
Copy link
Contributor

sttts commented Mar 2, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit ccb5fea into openshift:master Mar 2, 2020
@openshift-cherrypick-robot
Copy link

@p0lyn0mial: #327 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/operator/workloadcontroller/workload_controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/workloadcontroller/workload_controller.go
CONFLICT (content): Merge conflict in pkg/operator/workloadcontroller/workload_controller.go
Patch failed at 0001 waits for requestheader-client-ca-file in extension-apiserver-authentication before rolling out a new version

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@p0lyn0mial @openshift-cherrypick-robot @sttts @openshift-ci-robot @openshift-merge-robot