Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1814621: storage urls observer: prevent event/log spam #339

Merged
merged 1 commit into from Mar 20, 2020
Merged

Bug 1814621: storage urls observer: prevent event/log spam #339

merged 1 commit into from Mar 20, 2020

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Mar 18, 2020

DeepEqual fails on type comparison resulting in spamming update events

@stlaz
storage urls observer: prevent event/log spam
4187d03 
DeepEqual fails on type comparison resulting in spamming update events
@openshift-ci-robot
Copy link

@stlaz: This pull request references Bugzilla bug 1814621, which is invalid:

  • expected dependent Bugzilla bug 1814618 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1814621: storage urls observer: prevent event/log spam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 18, 2020
@mfojtik
Copy link
Member

mfojtik commented Mar 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@mfojtik mfojtik added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 18, 2020
@mfojtik
Copy link
Member

mfojtik commented Mar 18, 2020

This is worth fixing and we don't have to wait for QE to verify that this is gone, we know it is :-)

@stlaz stlaz mentioned this pull request Mar 19, 2020
Closed
@mfojtik mfojtik added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 59eabea into openshift:release-4.4 Mar 20, 2020
@openshift-ci-robot
Copy link

@stlaz: All pull requests linked via external trackers have merged. Bugzilla bug 1814621 has been moved to the MODIFIED state.

In response to this:

Bug 1814621: storage urls observer: prevent event/log spam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stlaz @openshift-ci-robot @mfojtik @openshift-bot @openshift-merge-robot