connectivitycheckcontroller: sync w/ kube-apiserver improvements #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sanchezl
commented
Aug 5, 2020
•
sanchezl
commented
- name some endpoints using node names to exploit dynamic check updates
- add checks for load balancers
- refactor to make it easier to use conectivitycheckcontroller from library-go in the future.
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
sanchezl
force-pushed
the
connectivitycheckcontroller-lb
branch
from
e70114f
to
2f34985
Compare
sanchezl
force-pushed
the
connectivitycheckcontroller-lb
branch
from
2f34985
to
cacc5a7
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
well, CI results are down. looks ok, but I can't verify the output. This looks to be converging with what I wrote in kas /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.