Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectivitycheckcontroller: use generic controller #380

Merged
merged 3 commits into from
Aug 17, 2020
Merged

connectivitycheckcontroller: use generic controller #380

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26db5bb
bump(*)
sanchezl Aug 7, 2020
c33ef36
react to bump(*)
sanchezl Aug 10, 2020
539953b
connectivitycheckcontroller: use generic check controller
sanchezl Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/operator/starter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func RunOperator(ctx context.Context, controllerConfig *controllercmd.Controller
configInformers.Config().V1().Images().Informer(),
).WithStaticResourcesController(
"APIServerStaticResources",
libgoassets.WithAuditPolicies(operatorclient.TargetNamespace, v311_00_assets.Asset),
libgoassets.WithAuditPolicies("audit", operatorclient.TargetNamespace, v311_00_assets.Asset),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

[]string{
"v3.11.0/openshift-apiserver/ns.yaml",
"v3.11.0/openshift-apiserver/apiserver-clusterrolebinding.yaml",
Expand Down Expand Up @@ -275,7 +275,7 @@ func RunOperator(ctx context.Context, controllerConfig *controllercmd.Controller
kubeInformersForNamespaces,
controllerConfig.EventRecorder,
)
auditPolicyPahGetter, err := libgoassets.NewAuditPolicyPathGetter()
auditPolicyPahGetter, err := libgoassets.NewAuditPolicyPathGetter("/var/run/configmaps/audit")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good.

if err != nil {
return err
}
Expand Down