New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1878648: oauth-apiserver: audit log oauthaccesstokens if fresh 4.6 install #392
Bug 1878648: oauth-apiserver: audit log oauthaccesstokens if fresh 4.6 install #392
Conversation
@sttts: This pull request references Bugzilla bug 1878648, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dcca6e7
to
5f38941
Compare
/retest |
return err | ||
} | ||
|
||
// TODO(4.7): switch over to secure access-token logging by default and delete old non-sha256 tokens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sttts maybe we should create a BZ for this and set target release to 4.7 so we can track it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sttts I created this BZ to track this: https://bugzilla.redhat.com/show_bug.cgi?id=1879182
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
pkg/operator/starter.go
Outdated
|
||
// TODO(4.7): switch over to secure access-token logging by default and delete old non-sha256 tokens | ||
auditPolicyPathGetterWithAccessTokenLogs := func(profile string) (string, error) { | ||
if apiServerConfig.Annotations["oauth-apiserver.openshift.io/secure-oauth-token-storage"] == "true" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the user removes the annotation from the APIServer object or set it to false? The apiServerConfig
object is stale once it is changed by the user. May be I am misunderstanding the flow here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will now redeploy with the old policy.
3c3ef01
to
f70fc6a
Compare
/retest |
@sttts: This pull request references Bugzilla bug 1878648, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
f70fc6a
to
0954258
Compare
0954258
to
7d1c06c
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sttts: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1878648 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Counterpart to openshift/cluster-authentication-operator#324.
The annotation
oauth-apiserver.openshift.io/secure-token-storage: true
set on the config/v1 apiserver object make openshift-apiserver deeply log oauth tokens, noth access and authorize (if openshift-apiserver is responsible for this; in fresh 4.6 install it is not, but oauth-apiserver is).This requires that there are no non-sha256 tokens in the system. For 4.6 installs this is guaranteed.
After downgrade to 4.5 there is a controller removing the annotation.
After upgrade from 4.5, the annotation is not set. The admin can set it manually after having made sure that no non-sha256 tokens exist.
For upgrade to 4.7, non-sha256 tokens must not exist. If they do, the upgrade will be blocked by the auth operator (to be implemented).