Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1998031: Deploy PDB to prevent more than one replica going unavailable #472

Merged
merged 1 commit into from Sep 1, 2021
Merged

bug 1998031: Deploy PDB to prevent more than one replica going unavailable #472

merged 1 commit into from Sep 1, 2021

Conversation

ingvagabund
Copy link
Member

In case master nodes are drained to quickly in a row there's no
waiting until instances go back to available. So it's possible
for two or more replicas to go unavailable which may lead
to all instances going unavailable.

Based on openshift/library-go@8efd188

@ingvagabund
Deploy PDB to prevent more than one replica going unavailable
181632a 
In case master nodes are drained to quickly in a row there's no
waiting until instances go back to available. So it's possible
for two or more replicas to go unavailable which may lead
to all instances going unavailable.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@ingvagabund: This pull request references Bugzilla bug 1998031, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 1998031: Deploy PDB to prevent more than one replica going unavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from soltysh and sttts August 31, 2021 12:38
@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

Checking kube_deployment_status_replicas_available{namespace="openshift-apiserver"} in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-openshift-apiserver-operator/472/pull-ci-openshift-cluster-openshift-apiserver-operator-master-e2e-upgrade/1432684183011987456 I see at most 1 replica unavailable during the upgrade. Let's kick it few times in a row to see if it goes up or stays at 1.

@ingvagabund
Copy link
Member Author

/test e2e-upgrade

@ingvagabund
Copy link
Member Author

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-openshift-apiserver-operator/472/pull-ci-openshift-cluster-openshift-apiserver-operator-master-e2e-upgrade/1432730715304235008 with at most 1 replica unavailable

@ingvagabund
Copy link
Member Author

/retest

p0lyn0mial
p0lyn0mial reviewed Sep 1, 2021
View reviewed changes
bindata/v3.11.0/openshift-apiserver/pdb.yaml
maxUnavailable: 1
selector:
matchLabels:
app: openshift-apiserver-a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, it matches https://github.com/openshift/cluster-openshift-apiserver-operator/blob/master/bindata/v3.11.0/openshift-apiserver/deploy.yaml#L33

@p0lyn0mial
Copy link
Contributor

/lgtm

@p0lyn0mial
Copy link
Contributor

/assign @sttts

for final approval

@p0lyn0mial
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@ingvagabund
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@ingvagabund: This pull request references Bugzilla bug 1998031, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 1, 2021
@openshift-ci openshift-ci bot mentioned this pull request Sep 1, 2021
Merged
@ingvagabund
Copy link
Member Author

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-openshift-apiserver-operator/472/pull-ci-openshift-cluster-openshift-apiserver-operator-master-e2e-upgrade/1432781343044931584 with at most 1 replica unavailable

@deads2k
Copy link
Contributor

deads2k commented Sep 1, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ingvagabund, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4cc29cf into openshift:master Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 1998031 has been moved to the MODIFIED state.

In response to this:

bug 1998031: Deploy PDB to prevent more than one replica going unavailable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the deploy-pdb-for-apiserver branch September 1, 2021 12:32
@ingvagabund
Copy link
Member Author

/cherrypick release-4.8
/cherrypick release-4.7

@openshift-cherrypick-robot
Copy link

@ingvagabund: #472 failed to apply on top of branch "release-4.8":

Applying: Deploy PDB to prevent more than one replica going unavailable
Using index info to reconstruct a base tree...
M	pkg/operator/starter.go
M	pkg/operator/v311_00_assets/bindata.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/v311_00_assets/bindata.go
Auto-merging pkg/operator/starter.go
CONFLICT (content): Merge conflict in pkg/operator/starter.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Deploy PDB to prevent more than one replica going unavailable
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.8
/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 14, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

@xingxingxia xingxingxia Awaiting requested review from xingxingxia

Assignees

@sttts sttts

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ingvagabund @p0lyn0mial @deads2k @openshift-cherrypick-robot @sttts @openshift-merge-robot