Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-408: bindata: set required-scc #544

Merged
merged 1 commit into from Jul 23, 2023

Conversation

s-urbaniak
Copy link
Contributor

This sets the required-scc annotation for openshift-apiserver to privileged as openshift-apiserver is a privileged pod.

/cc @deads2k @stlaz

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 13, 2023

@s-urbaniak: This pull request references AUTH-408 which is a valid jira issue.

In response to this:

This sets the required-scc annotation for openshift-apiserver to privileged as openshift-apiserver is a privileged pod.

/cc @deads2k @stlaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from deads2k and stlaz July 13, 2023 14:34
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

@s-urbaniak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@s-urbaniak
Copy link
Contributor Author

Verified that the right SCC is being picked:

$ cat namespaces/openshift-apiserver/core/pods.yaml
...
---
apiVersion: v1
items:
- apiVersion: v1
  kind: Pod
  metadata:
    annotations:
...
      openshift.io/required-scc: privileged
      openshift.io/scc: privileged
...

@s-urbaniak
Copy link
Contributor Author

just fyi, looking at other PRs it used to be node-exporter before :-|

---
apiVersion: v1
items:
- apiVersion: v1
  kind: Pod
  metadata:
    annotations:
...
      openshift.io/scc: node-exporter

@stlaz
Copy link
Member

stlaz commented Jul 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@mfojtik
Copy link
Member

mfojtik commented Jul 23, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 400e93f into openshift:master Jul 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants