Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase to 1.14.0 #101

Merged
merged 4 commits into from May 30, 2019
Merged

Rebase to 1.14.0 #101

merged 4 commits into from May 30, 2019

Conversation

adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented May 21, 2019 •
edited

  • Bump golang to 1.12
  • Bump deps to kube 1.14.0

JIRA: https://jira.coreos.com/browse/DEVEXP-321

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 21, 2019
@adambkaplan
Copy link
Contributor Author

/assign @deads2k
/cc @mfojtik @gabemontero

Followed openshift/cluster-kube-controller-manager-operator#255

@openshift-ci-robot openshift-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 21, 2019
@adambkaplan
Copy link
Contributor Author

@deads2k @mfojtik bump

@mfojtik
Copy link
Member

mfojtik commented May 29, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2019
@mfojtik
Copy link
Member

mfojtik commented May 29, 2019

/approve

1 similar comment
@sttts
Copy link
Contributor

sttts commented May 29, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2019
@adambkaplan
Copy link
Contributor Author

fyi @stevekuznetsov looks like prow required an additional approver due to changes in k8s owner files? Shouldn't prow ignore vendored code?

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Member

mfojtik commented May 30, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit b01fb05 into openshift:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero Awaiting requested review from gabemontero

@mfojtik mfojtik Awaiting requested review from mfojtik

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@mfojtik mfojtik

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@adambkaplan @mfojtik @sttts @openshift-ci-robot @openshift-bot @deads2k @openshift-merge-robot