New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monitoring: move service monitor RBAC rules to manifests/ #130
monitoring: move service monitor RBAC rules to manifests/ #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/retest |
@s-urbaniak please tag |
/lgtm |
/hold |
manifests/0000_90_openshift-controller-manager-operator_03_operand-servicemonitor.yaml
Outdated
Show resolved
Hide resolved
ce042e2
to
a9b80bd
Compare
/lgtm |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/hold cancel |
These are deployed by monitoring operator, but shouldn't: https://github.com/openshift/cluster-monitoring-operator/blob/e515ed03618466b6a1b9d2fcf12192191bfd90f8/assets/prometheus-k8s/role-specific-namespaces.yaml#L51-L66