Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default config to its own path #138

Merged
merged 2 commits into from Feb 20, 2020
Merged

Move default config to its own path #138

merged 2 commits into from Feb 20, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Feb 4, 2020

/cc @sttts

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2020
@adambkaplan
Copy link
Contributor

@marun this can be squashed into a single commit.

Note that since we are past feature freeze, we need a Bugzilla to merge any PR.

@marun
Copy link
Contributor Author

marun commented Feb 4, 2020

@adambkaplan If you care to have this fix in this release, maybe you could file the BZ? Otherwise it could wait. I'm just trying to be helpful here, not make work for myself or anyone else.

Edit: My apologies, I confused this PR with another in a different repo. Thanks for reminding me of the BZ requirement, I'll hold the PR for next release.

@marun
Copy link
Contributor Author

marun commented Feb 4, 2020

/hold

Waiting for 4.5, this is not worth filing a bz for.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2020
@marun
Copy link
Contributor Author

marun commented Feb 19, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2020
@marun
Copy link
Contributor Author

marun commented Feb 19, 2020

/retest

1 similar comment
@marun
Copy link
Contributor Author

marun commented Feb 19, 2020

/retest

@sttts
Copy link
Contributor

sttts commented Feb 20, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3e3b636 into openshift:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants