OCPBUGS-18498: Disable BuildConfigChange controller when Build cap is disabled

[ardaguclu]

With this #291, we have an ability to disable controllers if the capability they are belonging to is disabled.

But BuildConfigChange controller also belongs to Build capability and this PR adds it to the capability list. If Build cap
is disabled, openshift-controller-manager should not run BuildConfigChange controller.

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-18498, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

With this #291, we have an ability to disable controllers if the capability they are belonging to is disabled.

But BuildConfigChange controller also belongs to Build capability and this PR adds it to the capability list. If Build cap
is disabled, openshift-controller-manager should not run BuildConfigChange controller.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ardaguclu]

/hold
we verify that this works;

/cc @ingvagabund

[ardaguclu]

/jira refresh
I think, after the verification, we need to backport this PR and the next PR(another one for informers) in 4.14.

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-18498, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh
I think, after the verification, we need to backport this PR and the next PR(another one for informers) in 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ardaguclu]

/cc @kasturinarra

[openshift-ci]

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ardaguclu]

This is the other PR openshift/openshift-controller-manager#270

[ardaguclu]

/hold cancel

[ingvagabund]

/approve

[ingvagabund]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ingvagabund]

/label acknowledge-critical-fixes-only
This is a critical fix as vanilla clusters with Build/DC cap disabled will cause the OCM to restart.

[openshift-ci-robot]

@ardaguclu: Jira Issue OCPBUGS-18498: Some pull requests linked via external trackers have merged:

• openshift/cluster-openshift-controller-manager-operator#299

The following pull requests linked via external trackers have not merged:

• openshift/openshift-controller-manager#270 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-18498 has not been moved to the MODIFIED state.

In response to this:

With this #291, we have an ability to disable controllers if the capability they are belonging to is disabled.

But BuildConfigChange controller also belongs to Build capability and this PR adds it to the capability list. If Build cap
is disabled, openshift-controller-manager should not run BuildConfigChange controller.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ardaguclu]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@ardaguclu: new pull request created: #301

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.