Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-1666: add image pull secret cleanup controller #300

Merged
merged 2 commits into from Oct 27, 2023
Merged

API-1666: add image pull secret cleanup controller #300

merged 2 commits into from Oct 27, 2023

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Sep 12, 2023 •
edited

Builds on #298, adding ImagePullSecretCleanupController.

@sanchezl sanchezl changed the title image pull secret cleanup controller add image pull secret cleanup controller Sep 12, 2023
@sanchezl sanchezl mentioned this pull request Sep 12, 2023
Merged
@sanchezl
Copy link
Contributor Author

/retest

@sanchezl sanchezl force-pushed the image-pull-secret-cleanup-controller branch from 917bbf2 to 33f6254 Compare September 12, 2023 18:02
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2023
@flavianmissi
Copy link
Member

LGTM
I can tag it once it's rebased

@sanchezl sanchezl force-pushed the image-pull-secret-cleanup-controller branch from 33f6254 to a187aa4 Compare September 26, 2023 14:45
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2023
@flavianmissi
Copy link
Member

/lgtm
test failures look unrelated
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@sanchezl sanchezl force-pushed the image-pull-secret-cleanup-controller branch from a187aa4 to 2c424c6 Compare October 17, 2023 17:31
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@sanchezl sanchezl force-pushed the image-pull-secret-cleanup-controller branch from 2c424c6 to 103155c Compare October 20, 2023 12:52
@sanchezl sanchezl changed the title add image pull secret cleanup controller API-1642: add image pull secret cleanup controller Oct 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 20, 2023 •
edited by openshift-ci bot

@sanchezl: This pull request references API-1642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

Builds on #298, adding ImagePullSecretCleanupController.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl sanchezl force-pushed the image-pull-secret-cleanup-controller branch from 103155c to f5944e8 Compare October 23, 2023 17:48
@sanchezl
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

@sanchezl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f5944e8 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flavianmissi
Copy link
Member

LGTM from the registry's POV.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
soltysh
soltysh approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, sanchezl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@openshift-ci openshift-ci bot merged commit a84c9d4 into openshift:master Oct 27, 2023
8 of 9 checks passed
@sanchezl sanchezl changed the title API-1642: add image pull secret cleanup controller API-1666: add image pull secret cleanup controller Oct 27, 2023
@sanchezl
Copy link
Contributor Author

/jira refresh

@neisw neisw mentioned this pull request Oct 29, 2023
Merged
neisw added a commit to neisw/cluster-openshift-controller-manager-operator that referenced this pull request Oct 29, 2023
@neisw
Revert "Merge pull request openshift#300 from sanchezl/image-pull-sec…
f9ecfca 
…ret-cleanup-controller"

This reverts commit a84c9d4, reversing
changes made to 3fb9157.
openshift-ci bot added a commit that referenced this pull request Oct 30, 2023
@openshift-ci
Merge pull request #313 from neisw/revert-300-1698599424767
f45b3c5 
Revert #300 "API-1666: add image pull secret cleanup controller"
openshift-ci bot added a commit that referenced this pull request Nov 2, 2023
@openshift-ci
Merge pull request #314 from sanchezl/revert-revert-api-1666
e6f885a 
Revert "Revert #300 "API-1666: add image pull secret cleanup controller""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@bparees bparees Awaiting requested review from bparees

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@flavianmissi flavianmissi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sanchezl @flavianmissi @openshift-ci-robot @soltysh @openshift-merge-robot