Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-20164: Include Build CRD in manifests #306

Merged
merged 2 commits into from Oct 12, 2023

Conversation

adambkaplan
Copy link
Contributor

Include the build CRD in ocm-o's manifests, so it is decoupled by the cluster-config operator. This allows the "Build" capability to be respected.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 12, 2023
@openshift-ci-robot
Copy link
Contributor

@adambkaplan: This pull request references Jira Issue OCPBUGS-20164, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @coreydaley

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Include the build CRD in ocm-o's manifests, so it is decoupled by the cluster-config operator. This allows the "Build" capability to be respected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
Update openshift/api to add the capability annotation to the Build CRD.
Include the build CRD in its manifests. This ensures capabilities are
respected and the build CRD is deployed on the cluster. Also include
an empty-resource instance for "default" installs by the CVO.
@adambkaplan adambkaplan changed the title WIP - OCPBUGS-20164: Include Build CRD in manifests OCPBUGS-20164: Include Build CRD in manifests Oct 12, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
@adambkaplan
Copy link
Contributor Author

@bparees @wking removed WIP. Per our discussion, we think this needs to land before openshift/cluster-config-operator#360

@bparees
Copy link
Contributor

bparees commented Oct 12, 2023

/approve

will let @wking do the lgtm honors/double-check

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

@adambkaplan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit bec461c into openshift:master Oct 12, 2023
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@adambkaplan: Jira Issue OCPBUGS-20164: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-20164 has not been moved to the MODIFIED state.

In response to this:

Include the build CRD in ocm-o's manifests, so it is decoupled by the cluster-config operator. This allows the "Build" capability to be respected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants