Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-31708: Update opentelemetry dependency 415 #342

Merged
merged 1 commit into from
May 2, 2024
Merged

[release-4.15] OCPBUGS-31708: Update opentelemetry dependency 415 #342

merged 1 commit into from
May 2, 2024

Conversation

apoorvajagtap
Copy link
Contributor

@apoorvajagtap apoorvajagtap commented Apr 3, 2024 •
edited

Bumps (primarily):

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46.0 [OCPBUGS-31708]
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0 [OCPBUGS-31683]
& related go.opentelemetry.io dependencies

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 3, 2024
@openshift-ci-robot
Copy link
Contributor

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-31708, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-23848 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-23848 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bumps (primarily):

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0
& related go.opentelemetry.io dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@apoorvajagtap apoorvajagtap force-pushed the update-opentelemetry-dependency-415 branch from 952fbe7 to 83242b1 Compare April 4, 2024 05:55
@apoorvajagtap
Copy link
Contributor Author

/test openshift-e2e-aws-builds-techpreview

1 similar comment
@apoorvajagtap
Copy link
Contributor Author

/test openshift-e2e-aws-builds-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024 •
edited

@apoorvajagtap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 83242b1 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@apoorvajagtap
Copy link
Contributor Author

/test openshift-e2e-aws-builds-techpreview

@sayan-biswas
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apoorvajagtap, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 30, 2024
@openshift-ci-robot
Copy link
Contributor

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-31708, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-32293 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-32293 to target a version in 4.16.0, but it targets "4.16" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bumps (primarily):

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46.0 [OCPBUGS-31708]
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0 [OCPBUGS-31683]
& related go.opentelemetry.io dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@apoorvajagtap
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-31708, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@apoorvajagtap
Copy link
Contributor Author

/backport-risk-assessed

@apoorvajagtap
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2024
@openshift-ci-robot
Copy link
Contributor

@apoorvajagtap: This pull request references Jira Issue OCPBUGS-31708, which is valid.

11 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-32293 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent bug Jira Issue OCPBUGS-32477 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent bug Jira Issue OCPBUGS-23848 is in the state Release Pending (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32293 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • dependent Jira Issue OCPBUGS-32477 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • dependent Jira Issue OCPBUGS-23848 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@apoorvajagtap
Copy link
Contributor Author

/label backport-risk-assessed
/label cherry-pick-approved

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels May 2, 2024
@apoorvajagtap
Copy link
Contributor Author

/cherrypick release-4.14

@openshift-cherrypick-robot
Copy link

@apoorvajagtap: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9c4fb81 into openshift:release-4.15 May 2, 2024
8 of 9 checks passed
@openshift-ci-robot
Copy link
Contributor

@apoorvajagtap: Jira Issue OCPBUGS-31708: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31708 has been moved to the MODIFIED state.

In response to this:

Bumps (primarily):

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46.0 [OCPBUGS-31708]
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0 [OCPBUGS-31683]
& related go.opentelemetry.io dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-openshift-controller-manager-operator-container-v4.15.0-202405021207.p0.g9c4fb81.assembly.stream.el9 for distgit ose-cluster-openshift-controller-manager-operator.
All builds following this will include this PR.

@apoorvajagtap apoorvajagtap deleted the update-opentelemetry-dependency-415 branch May 3, 2024 07:19
@sayan-biswas
Copy link

/cherry-pick release-4.14

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-05-04-030917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendar-singh jitendar-singh Awaiting requested review from jitendar-singh

@bparees bparees Awaiting requested review from bparees

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@sayan-biswas sayan-biswas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@apoorvajagtap @openshift-ci-robot @sayan-biswas @openshift-cherrypick-robot @openshift-bot @openshift-merge-robot