Add more logs for queue operations #122
Conversation
There was a problem hiding this comment.
is another point of contention that could stop the works. Can you please add to the end of the function?
klog.V(2).Infof("synced cluster resource quota controller")I have not seen any discovery/monitor failures in KCM in the failed jobs, but it is generally good to know when the syncing has finished since it can freeze the work
| @@ -91,6 +96,7 @@ func (e *workQueueBucket) GetWithData() (interface{}, []interface{}, bool) { | |||
| return nil, []interface{}{}, shutdown | |||
| } | |||
|
|
|||
| klog.V(2).Infof("key %s is gotten from queue", key) | |||
There was a problem hiding this comment.
please add the print after the lock to preserve a raciness, if there is one
There was a problem hiding this comment.
I'll use this one to prove that item is obtained from queue and to ensure that the raciness, I've added klog.V(2).Infof("lock acquired and key % is added in progress list", key)
There was a problem hiding this comment.
ack, let's see what we get with this
ardaguclu
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
ardaguclu
force-pushed
the
add-logs-for-queue
branch
from
24fe175
to
3b02a25
Compare
|
Thanks for review @atiratree. Updated according to your suggestions. |
ardaguclu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ardaguclu
force-pushed
the
add-logs-for-queue
branch
from
3b02a25
to
2a9b7b4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, atiratree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
this extra logging is required for debugging purposes and should be remove in the future |
I'll open a revert PR, once we sort out the problem. |
|
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.