ps syncer: add a controller for run-level 0 namespaces #128
Conversation
openshift-ci
bot
added
the
approved
| factory.NamesFilter("default", "kube-system", "kube-public"), | ||
| namespaceInformer.Informer(), | ||
| ). | ||
| ResyncEvery(1*time.Hour). |
| nsLister: namespaceInformer.Lister(), | ||
| } | ||
|
|
||
| return factory.New(). |
There was a problem hiding this comment.
you sure you want to layer on this? I won't nak it, but if it's only saving 50 lines of boiler plate are you sure it's worth the trust that it works?
|
Great use of apply. Looks great. Question about boiler plate versus trust. /lgtm holding in case you want another reviewer. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm cancel |
stlaz
force-pushed
the
psa_privileged_syncer
branch
from
33b7970
to
50b1535
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
stlaz
force-pushed
the
psa_privileged_syncer
branch
from
50b1535
to
bd14bf4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stlaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
||
| namespaceInformer.Informer().AddEventHandler( | ||
| cache.FilteringResourceEventHandler{ | ||
| FilterFunc: factory.NamesFilter("default", "kube-system", "kube-public"), |
There was a problem hiding this comment.
One question, why omit the kube-node-lease namespace here?
/cc @deads2k
/cc @ibihim