Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRKLDS-806: bump k8s to 1.28 #132

Merged
merged 4 commits into from Sep 25, 2023
Merged

WRKLDS-806: bump k8s to 1.28 #132

merged 4 commits into from Sep 25, 2023

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Sep 20, 2023 •
edited

includes an override to vendor the release-1.28 branch sooner before it is released: 2fff150

to fix the failing builds: #132 (comment)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2023 •
edited by openshift-ci bot

@atiratree: This pull request references WRKLDS-806 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but it targets "openshift-4.14" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@atiratree atiratree mentioned this pull request Sep 20, 2023
Merged
@atiratree
Copy link
Member Author

/hold

build failing with

 # github.com/openshift/cluster-policy-controller/pkg/quota/clusterquotareconciliation
pkg/quota/clusterquotareconciliation/reconciliation_controller.go:104:22: undefined: resourcequota.NewMonitor

requires an upstream regression fix kubernetes/kubernetes#120777

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@copejon
Copy link

copejon commented Sep 22, 2023

/retest

@atiratree
Copy link
Member Author

added an override to vendor the release-1.28 branch sooner before it is released: 2fff150

the tests should pass now

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 22, 2023 •
edited by openshift-ci bot

@atiratree: This pull request references WRKLDS-806 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

includes an override to vendor the release-1.28 branch sooner before it is released: 2fff150

to fix the failing builds: #132 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@atiratree
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2023
soltysh
soltysh approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2b2da0c into openshift:master Sep 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atiratree @openshift-ci-robot @copejon @soltysh @openshift-merge-robot