Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSR: fix the subject for monitoring CSRs approval #66

Merged
merged 1 commit into from Jul 14, 2021
Merged

CSR: fix the subject for monitoring CSRs approval #66

merged 1 commit into from Jul 14, 2021

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Jul 13, 2021 •
edited

Looks like the CSRs actually don't prepend the CN with a slash.

/assign @slaskawi

@openshift-ci openshift-ci bot requested review from mfojtik and sanchezl July 13, 2021 08:09
slaskawi
slaskawi approved these changes Jul 13, 2021
View reviewed changes
Copy link

@slaskawi slaskawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@stlaz
Copy link
Member Author

stlaz commented Jul 13, 2021

/retest

soltysh
soltysh approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@soltysh
Copy link
Member

soltysh commented Jul 13, 2021

/retest

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanchezl, slaskawi, soltysh, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3694121 into openshift:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@sanchezl sanchezl sanchezl approved these changes

@slaskawi slaskawi slaskawi approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@slaskawi slaskawi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stlaz @soltysh @openshift-bot @sanchezl @slaskawi @openshift-merge-robot