Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to client go #207

Merged

Conversation

gabemontero
Copy link
Contributor

now that @ricardomaraschini 's openshift/client-go#123 has merged

/assgin @ricardomaraschini
/assign @adambkaplan
@openshift/openshift-team-developer-experience FYI

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@gabemontero
Copy link
Contributor Author

green tests on this switch to client-go for samples operator PR

@dmage
Copy link
Member

dmage commented Dec 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@ricardomaraschini
Copy link

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, gabemontero, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor Author

gabemontero commented Dec 11, 2019

some mysql deployment resource constraint looking pain in the failed image_ecosystem trying to see the count in the rendored app page
(certainly not related to which client is used for the samples operator CRD)

let's see how persistent the e2e failure is

/retest

@openshift-merge-robot openshift-merge-robot merged commit 8bbceb4 into openshift:master Dec 11, 2019
@gabemontero gabemontero deleted the switch-to-client-go branch December 11, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants