Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more work around metric unit tests flakes #259

Merged
merged 1 commit into from Apr 7, 2020
Merged

more work around metric unit tests flakes #259

merged 1 commit into from Apr 7, 2020

Conversation

gabemontero
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@gabemontero
Copy link
Contributor Author

/test unit

4 similar comments
@gabemontero
Copy link
Contributor Author

/test unit

@gabemontero
Copy link
Contributor Author

/test unit

@gabemontero
Copy link
Contributor Author

/test unit

@gabemontero
Copy link
Contributor Author

/test unit

@gabemontero
Copy link
Contributor Author

/retest
/test e2e-aws-operator

@gabemontero
Copy link
Contributor Author

ok, 1 pass with random port generation in unit test method

/test unit

@gabemontero
Copy link
Contributor Author

pass 2 green

/test unit

@gabemontero
Copy link
Contributor Author

pass 3 green

/test unit

@gabemontero
Copy link
Contributor Author

pass 4 green

/test unit

@gabemontero
Copy link
Contributor Author

pass 5 green

/test unit

@gabemontero
Copy link
Contributor Author

ok 6 straight unit test passes per https://prow.svc.ci.openshift.org/pr-history/?org=openshift&repo=cluster-samples-operator&pr=259

think this one is finally sorted out

/assign @coreydaley

@coreydaley
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. labels Apr 7, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f8d36d7 into openshift:master Apr 7, 2020
@gabemontero gabemontero deleted the more-unit-test branch April 7, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@dmage dmage Awaiting requested review from dmage

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@coreydaley coreydaley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gabemontero @coreydaley @openshift-bot @openshift-ci-robot @openshift-merge-robot