samples bump for 4.5 #262
samples bump for 4.5 #262
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
two of the cakephp / mysql tests in image eco has issues and sure enough the templates still reference the mysql:5.7 IST, like https://github.com/openshift/cluster-samples-operator/blob/master/tmp/build/assets/operator/ocp-x86_64/cakephp/templates/cakephp-mysql-example.json#L421 but that tag was deleted adding it back in for now, and will open an upstream PR to address ... most likely will miss the 4.5 drop, and will have to wait until 4.6 |
gabemontero
force-pushed
the
45-samples-bump
branch
from
cca984b
to
7f2cefb
Compare
|
did get clean build and jenkins e2e runs so that was good |
|
/test e2e-aws-image-ecosystem |
|
/test e2e-aws |
|
image eco now clean with mysql IS revert for cakephp |
|
on mysql / cakephp - I forgot this came up in Jan during 4.4 feature freeze and I have sclorg/cakephp-ex#113 up for the scl team turns out mysql 8.0 image updates were needed to get things to work it would appear those are ready now, but I've queried SCL in that PR about propagating things |
No description provided.