Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1843949: pull in sso compatibility fixes for 4.5 and above #284

Merged
merged 1 commit into from Jun 4, 2020

Conversation

gabemontero
Copy link
Contributor

/assign @marun

heads up, sso-cd-x509-https.json was not previously shipped with OCP, so its deletion in openshift/library did not need to occur here.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2020
@gabemontero
Copy link
Contributor Author

I'll cherry pick back to 4.5 and use your BZ after you lgtm this and it merges @marun

@marun
Copy link

marun commented Jun 3, 2020

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. labels Jun 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marun
Copy link

marun commented Jun 3, 2020

/retest

1 similar comment
@marun
Copy link

marun commented Jun 3, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f573ba4 into openshift:master Jun 4, 2020
@gabemontero gabemontero deleted the marus-sso-fix branch June 4, 2020 00:54
@gabemontero
Copy link
Contributor Author

/cherrypick release-4.5

@openshift-cherrypick-robot

@gabemontero: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cluster-samples-operator\n ! [remote rejected] cherry-pick-284-to-release-4.5 -> cherry-pick-284-to-release-4.5 (cannot lock ref 'refs/heads/cherry-pick-284-to-release-4.5': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/cluster-samples-operator'\n", error: exit status 1

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gabemontero: new pull request created: #286

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero changed the title pull in sso compatibility fixes for 4.5 and above Bug 1843949: pull in sso compatibility fixes for 4.5 and above Jun 4, 2020
@openshift-ci-robot
Copy link
Contributor

@gabemontero: An error was encountered updating to the MODIFIED state for bug 1843949 on the Bugzilla server at https://bugzilla.redhat.com:

code 32000: Red Hat Bugzilla's database reported a query serialization error. Most likely this occurred because another user or process attempted to change the same data that you were attempting to change. Please press Back and retry the transaction.

 UPDATE bugs SET bug_status = ? WHERE bug_id = ? at /var/www/html/bugzilla/Bugzilla/Object.pm line 544. Bugzilla::Object::update('Bugzilla::Bug=HASH(0x563e2684cc30)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1168 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x563e2684cc30)') called at /var/www/html/bugzilla/Bugzilla/WebService/Bug.pm line 851 Bugzilla::WebService::Bug::update('Bugzilla::WebService::Server::REST::Bugzilla::WebService::Bug...', 'HASH(0x563e261f2010)') called at (eval 2623) line 1 eval ' $procedure->{code}->($self, $params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 208 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::REST::Bugzilla::WebService::Bug...', 'HASH(0x563e264b4ec0)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::REST::Bugzilla::WebService::Bug...', 'HASH(0x563e264b4ec0)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/REST.pm line 98 Bugzilla::WebService::Server::REST::handle('Bugzilla::WebService::Server::REST::Bugzilla::WebService::Bug...') called at /var/www/html/bugzilla/rest.cgi line 30 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_rest_2ecgi::handler('Apache2::RequestRec=SCALAR(0x563e26e60d78)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x563e263df1e0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x563e263df1e0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x563e26e60d78)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x563e26e60d78)') called at (eval 2623) line 0 eval {...} called at (eval 2623) line 0 

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1843949: pull in sso compatibility fixes for 4.5 and above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@gabemontero: All pull requests linked via external trackers have merged: . Bugzilla bug 1843949 has been moved to the MODIFIED state.

In response to this:

Bug 1843949: pull in sso compatibility fixes for 4.5 and above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants