Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync w/ library for updating jenkins nodejs agent image #329

Merged
merged 1 commit into from Oct 6, 2020

Conversation

waveywaves
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 6, 2020

@waveywaves: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws-builds 530f0cd link /test okd-e2e-aws-builds
ci/prow/okd-e2e-aws 530f0cd link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor

non related flakes in e2e failures

/lgtm

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@gabemontero
Copy link
Contributor

quick reminder @waveywaves .... technically speaking, the jenkins updates here do not matter, since samples operator overrides the jenkins image references with references to the jenkins images in the install payload

but I'm okay with keeping it consistent for consistency sake

@openshift-merge-robot openshift-merge-robot merged commit a543ba6 into openshift:master Oct 6, 2020
@waveywaves
Copy link
Contributor Author

@gabemontero Understood. Will keep that in mind. Thanks for reminding me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants