Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add current profile annotations to CVO manifests #334

Merged
merged 1 commit into from Oct 23, 2020

Conversation

guillaumerose
Copy link
Contributor

This is matches openshift/enhancements#414 and doesn't change existing behavior

This is matches openshift/enhancements#414 and doesn't change existing behavior
@gabemontero
Copy link
Contributor

/approve

will lgtm when tests are green

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@deads2k
Copy link
Contributor

deads2k commented Oct 23, 2020

/lgtm
/hold

holding for @gabemontero 's request for green tests. Feel free to release hold after.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, gabemontero, guillaumerose

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor

some network operator degraded cluster install errors are coming in ... will retest for those, but will let the entire initial pass complete first, see if anything of the non-flake variety comes in

@gabemontero
Copy link
Contributor

OK have some clean OCP e2e's

Let's see if we can get one clean OKD run and I'll release the hold

/test okd-e2e-aws-operator

@gabemontero
Copy link
Contributor

hey @vrutkovs - the network operator / ovn node stuff is consistently crash looping in the okd e2e's (but are clean in the ocp e2e variants)

would you happen to know if this is a known okd issue?

scoping out a couple of the pod logs, I see

I1023 17:35:46.604274   21329 config.go:919] exec: /usr/bin/ovs-vsctl --timeout=15 set Open_vSwitch . external_ids:ovn-nb="ssl:10.0.148.244:9641,ssl:10.0.176.27:9641,ssl:10.0.219.56:9641" => exit status 1
F1023 17:35:46.604318   21329 ovnkube.go:130] error setting OVS external ID 'ovn-nb="ssl:10.0.148.244:9641,ssl:10.0.176.27:9641,ssl:10.0.219.56:9641"': exit status 1

I have another samples operator PR running tests now that passed okd e2e's recently ... I'll compare those results with these

if I see the same thing in both PRs, and this appears to be a new okd regression @guillaumerose @deads2k I'll override the okd e2e an try to merge this PR

@gabemontero
Copy link
Contributor

gabemontero commented Oct 23, 2020

yep see the same thing in my BUILD-125 PR

/hold cancel

/override ci/prow/okd-e2e-aws
/override ci/prow/okd-e2e-aws-builds
/override ci/prow/okd-e2e-aws-image-ecosystem
/override ci/prow/okd-e2e-aws-jenkins
/override ci/prow/okd-e2e-aws-operator
/override ci/prow/okd-e2e-aws-upgrade

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2020

@gabemontero: Overrode contexts on behalf of gabemontero: ci/prow/okd-e2e-aws, ci/prow/okd-e2e-aws-builds, ci/prow/okd-e2e-aws-image-ecosystem, ci/prow/okd-e2e-aws-jenkins, ci/prow/okd-e2e-aws-operator, ci/prow/okd-e2e-aws-upgrade

In response to this:

yep see the same thing in my BUILD-125 PR

/hold cancel

/override ci/prow/okd-e2e-aws
/override ci/prow/okd-e2e-aws-builds
/override ci/prow/okd-e2e-aws-image-ecosystem
/override ci/prow/okd-e2e-aws-jenkins
/override ci/prow/okd-e2e-aws-operator
/override ci/prow/okd-e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 64613f6 into openshift:master Oct 23, 2020
@vrutkovs
Copy link
Member

MCO is broken in master, sorry about that :/ 4.6 cherrypicks should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants