Add aarch64 support #335
Add aarch64 support #335
Conversation
The openshift/api update is needed for samples.v1.ARMArchitecture. openshift/library-go needed to be updated to avoid obsolete URLs in dependencies.
|
heads up @yselkowitz ... I've got a non-trivial refactor of samples operator cooking with #313 My initial scan of your changes (in particular 1a3146d) gives me confidence that these PRs will not hit conflicts. But that said, I will try to avoid having to rebase my PR if I can help it. I'm awaiting a review from @adambkaplan as I type ... if all goes OK, it should still be sometime next week when we can pull this in. And if a rebase here is needed, I would think it would be pretty straight forward given the simplicity of the changes you have in 1a3146d thanks |
openshift-ci-robot
added
the
approved
|
/hold Per @gabemontero 's comment regarding the refactor. If we're not waiting on this any more, then Gabe you can go ahead and add the lgtm. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/test okd-e2e-aws-operator |
|
OKD was working to some degree on Friday ... let's see how it is here. If it flakes for generic enough reasons, I'll override Also, depending on how the build-125 review progresses or does not progress today, I'll merge this by EOB and deal with any rebase issues there if need be tomorrow. |
|
/hold cancel /lgtm /retest I'll override any justifiably overriden OKD flakes but we'll give them one more go but okd-e2e-aws-operator looked OK |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This makes the cluster-samples-operator fully functional on aarch64
(arm64 in Go parlance). The revendoring is necessary to pick up
openshift/api#759.