Annotate manifests for single-node-developer cluster profile #343
Conversation
This partially implements phase 1 of https://github.com/openshift/enhancements#482 and does not change behavior. Initially, all cluster-samples-operator manifests are included in the single-node-developer cluster profile. Follow-on PRs may exclude any of these that are not needed in the profile.
cfergeau
force-pushed
the
single-node-developer
branch
from
acbd1d1
to
fac7f44
Compare
| include.release.openshift.io/single-node-production-edge: "true" | ||
| openshift.io/node-selector: "" |
There was a problem hiding this comment.
can you clarify / remind me the resulting behavior of the node-selector annotation setting above @cfergeau ?
There was a problem hiding this comment.
/hold
pending the answer to the above question
There was a problem hiding this comment.
The node-selector annotation is already there before this change, I moved it to group all include.release.openshift.io annotations together, but I'm only adding a include.release.openshift.io/single-node-developer: "true" annotation
Before:
annotations:
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
openshift.io/node-selector: ""
include.release.openshift.io/single-node-production-edge: "true"
After:
annotations:
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
include.release.openshift.io/single-node-developer: "true"
include.release.openshift.io/single-node-production-edge: "true"
openshift.io/node-selector: ""
There was a problem hiding this comment.
ahh ... sorry, missed that ... my bad
/hold cancel
/lgtm
|
/approve |
openshift-ci-robot
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cfergeau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all cluster-samples-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.