Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1990988: Refreshing samples for OCP 4.9 #381

Merged
merged 1 commit into from Aug 13, 2021
Merged

Bug 1990988: Refreshing samples for OCP 4.9 #381

merged 1 commit into from Aug 13, 2021

Conversation

dperaza4dustbit
Copy link
Contributor

Ran the library synch and sending the changes that resulted. Preliminary investigation looks good and script output looks like it did its job.

@gabemontero gabemontero mentioned this pull request Aug 8, 2021
Closed
@dperaza4dustbit
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dperaza4dustbit, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@dperaza4dustbit dperaza4dustbit changed the title Refreshing samples for OCP 4.9 Bug 1990988: Refreshing samples for OCP 4.9 Aug 12, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@dperaza4dustbit: This pull request references Bugzilla bug 1990988, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1990988: Refreshing samples for OCP 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dperaza4dustbit
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@dperaza4dustbit: This pull request references Bugzilla bug 1990988, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor

/skip

@gabemontero
Copy link
Contributor

/refresh

@gabemontero
Copy link
Contributor

/test e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@dperaza4dustbit: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws-jenkins 6e3ff46 link /test okd-e2e-aws-jenkins
ci/prow/okd-e2e-aws 6e3ff46 link /test okd-e2e-aws
ci/prow/e2e-aws-upgrade 6e3ff46 link /test e2e-aws-upgrade
ci/prow/okd-e2e-aws-builds 6e3ff46 link /test okd-e2e-aws-builds
ci/prow/okd-e2e-aws-image-ecosystem 6e3ff46 link /test okd-e2e-aws-image-ecosystem
ci/prow/okd-e2e-aws-upgrade 6e3ff46 link /test okd-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@gabemontero: Cannot get PR #381 in openshift/cluster-samples-operator: status code 403 not one of [200], body: {
"documentation_url": "https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits",
"message": "You have exceeded a secondary rate limit. Please wait a few minutes before you try again."
}

In response to this:

/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor

/skip

@gabemontero
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2021 •
edited

@dperaza4dustbit: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 6e3ff46 link /test okd-e2e-aws
ci/prow/okd-e2e-aws-jenkins 6e3ff46 link /test okd-e2e-aws-jenkins
ci/prow/okd-e2e-aws-image-ecosystem 6e3ff46 link /test okd-e2e-aws-image-ecosystem
ci/prow/okd-e2e-aws-builds 6e3ff46 link /test okd-e2e-aws-builds
ci/prow/okd-e2e-aws-upgrade 6e3ff46 link /test okd-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 0e65d7a into openshift:master Aug 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2021

@dperaza4dustbit: All pull requests linked via external trackers have merged:

Bugzilla bug 1990988 has been moved to the MODIFIED state.

In response to this:

Bug 1990988: Refreshing samples for OCP 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member

vrutkovs commented Aug 13, 2021 •
edited

This breaks OKD

fail [github.com/openshift/origin/test/extended/templates/templateinstance_readiness.go:107]: Unexpected error:
    <*errors.errorString | 0xc002068780>: {
        s: "Failed to import expected imagestreams, latest error status: ImageStream Error: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, ListMeta:v1.ListMeta{SelfLink:\"\", ResourceVersion:\"\", Continue:\"\", RemainingItemCount:(*int64)(nil)}, Status:\"Failure\", Message:\"imagestreams.image.openshift.io \\\"mongodb\\\" not found\", Reason:\"NotFound\", Details:(*v1.StatusDetails)(0xc000efa9c0), Code:404}} \n",
    }
    Failed to import expected imagestreams, latest error status: ImageStream Error: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:"", RemainingItemCount:(*int64)(nil)}, Status:"Failure", Message:"imagestreams.image.openshift.io \"mongodb\" not found", Reason:"NotFound", Details:(*v1.StatusDetails)(0xc000efa9c0), Code:404}} 
    
occurred

@gabemontero
Copy link
Contributor

This breaks OKD

fail [github.com/openshift/origin/test/extended/templates/templateinstance_readiness.go:107]: Unexpected error:
    <*errors.errorString | 0xc002068780>: {
        s: "Failed to import expected imagestreams, latest error status: ImageStream Error: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, ListMeta:v1.ListMeta{SelfLink:\"\", ResourceVersion:\"\", Continue:\"\", RemainingItemCount:(*int64)(nil)}, Status:\"Failure\", Message:\"imagestreams.image.openshift.io \\\"mongodb\\\" not found\", Reason:\"NotFound\", Details:(*v1.StatusDetails)(0xc000efa9c0), Code:404}} \n",
    }
    Failed to import expected imagestreams, latest error status: ImageStream Error: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:"", RemainingItemCount:(*int64)(nil)}, Status:"Failure", Message:"imagestreams.image.openshift.io \"mongodb\" not found", Reason:"NotFound", Details:(*v1.StatusDetails)(0xc000efa9c0), Code:404}} 
    
occurred

I'm a little confused @vrutkovs .... mongodb is not one of the imagestreams listed at https://github.com/openshift/origin/blob/c5feec4ee991a031fc6700f3d8c6083e1ef2c48b/test/extended/util/framework.go#L245

where that is the method called at https://github.com/openshift/origin/blob/master/test/extended/templates/templateinstance_readiness.go#L106

and yes, mongodb is gone from both OKD and OCP cause of the licensing hoopla with them.

Could you point us to whatever CI job this came from so we can look at must gather ?

@vrutkovs
Copy link
Member

Seems cluster-samples-operator is using 4.8 tests still - could you LGTM openshift/release#20055 so that it would use 4.9 on master?

@gabemontero
Copy link
Contributor

Seems cluster-samples-operator is using 4.8 tests still - could you LGTM openshift/release#20055 so that it would use 4.9 on master?

ahh ... that explains it ....forgot about that correlation

lgtm posted thanks @vrutkovs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

@jitendar-singh jitendar-singh Awaiting requested review from jitendar-singh

Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dperaza4dustbit @gabemontero @openshift-bot @openshift-ci-robot @vrutkovs