Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconcile status when clusteroperator changes #510

Merged
merged 2 commits into from Jul 18, 2023

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Jul 14, 2023

Needed for openshift/cluster-kube-apiserver-operator#1423.

If status is modified, the operator must set status to proper values. This ensures that accidents cannot permanently reset status and gives a clear indication that the operator is "live". This came up as important when operators were NOT live, during cert rotations and we had no indication of problems.

@sanchezl sanchezl changed the title master reconcile status when clusteroperator changes Jul 14, 2023
@gabemontero
Copy link
Contributor

/assign @fbm3307

@sanchezl
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn-image-ecosystem 2eb7285 link false /test okd-scos-e2e-aws-ovn-image-ecosystem
ci/prow/okd-e2e-aws-ovn-image-ecosystem 2eb7285 link false /test okd-e2e-aws-ovn-image-ecosystem
ci/prow/okd-scos-e2e-aws-ovn 2eb7285 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn-jenkins 2eb7285 link false /test okd-scos-e2e-aws-ovn-jenkins
ci/prow/okd-e2e-aws-ovn-upgrade 2eb7285 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2023

/lgtm

worked on clusterbot approving

@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dc90cbc and 2 for PR HEAD 2eb7285 in total

@fbm3307
Copy link
Contributor

fbm3307 commented Jul 18, 2023

@sanchezl @deads2k Please make sure all the required test pass before approving this PR

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2023

@sanchezl @deads2k Please make sure all the required test pass before approving this PR

It won't merge until tests pass

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2023

/hold

for @fbm3307

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@fbm3307
Copy link
Contributor

fbm3307 commented Jul 18, 2023

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, fbm3307, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f237c65 into openshift:master Jul 18, 2023
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants