Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SO-112: Install helmcharts via CSO #529

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

SO-112: Install helmcharts via CSO #529

wants to merge 11 commits into from

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Dec 12, 2023

This PR is to install Helmcharts via CSO as part of Downsizing phase-2

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2023 •
edited by openshift-ci bot

@fbm3307: This pull request references SO-112 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR is to install Helmcharts via CSO as part of Downsizing phase-2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 12, 2023
@fbm3307 fbm3307 marked this pull request as draft December 12, 2023 12:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@fbm3307
Copy link
Contributor Author

fbm3307 commented Dec 12, 2023 •
edited

/remove-approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2023
@fbm3307
SO-112: Install helmcharts via CSO
2336c3b 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
skip helmcharts
bc23f6f 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
testing the code
6762277 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2023
@fbm3307
fixing build
73a8333 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
editting the makefile
13b0c03 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307 fbm3307 marked this pull request as ready for review December 15, 2023 11:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2023
@fbm3307
Copy link
Contributor Author

fbm3307 commented Dec 18, 2023

/test e2e-aws

1 similar comment
@fbm3307
Copy link
Contributor Author

fbm3307 commented Dec 19, 2023

/test e2e-aws

@fbm3307
testing the odc s2i chart
3f8f29a 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
filariow
filariow reviewed Dec 19, 2023
View reviewed changes
pkg/stub/handler.go Outdated Show resolved Hide resolved
filariow
filariow reviewed Dec 19, 2023
View reviewed changes
pkg/stub/handler.go Outdated Show resolved Hide resolved
filariow
filariow reviewed Dec 19, 2023
View reviewed changes
pkg/stub/handler.go Outdated
Comment on lines 1508 to 1517
if k1 == "name" {
chartsValue.Name = fmt.Sprintf("%v", v1)
}
if k1 == "version" {
chartsValue.Version = fmt.Sprintf("%v", v1)
}
if k1 == "urls" {
chartsValue.churl = fmt.Sprintf("%v", v1)
chartsValue.churl = chartsValue.churl[1 : len(chartsValue.churl)-1]
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe using the switch statement here may be a good idea

@fbm3307 fbm3307 mentioned this pull request Dec 20, 2023
Closed
@fbm3307
adding the delete functionality
f914f09 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
Testing the delete and adding dotnet
f4c16a0 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
Updated Regex
3b98c63 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
Api go chnages
b1d206b 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307
go vendor fix
52a0516 
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@fbm3307: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-image-ecosystem 52a0516 link false /test okd-e2e-aws-ovn-image-ecosystem
ci/prow/e2e-aws-ovn-image-ecosystem 52a0516 link true /test e2e-aws-ovn-image-ecosystem
ci/prow/e2e-aws-ovn-upgrade 52a0516 link true /test e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn 52a0516 link false /test okd-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 52a0516 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn-jenkins 52a0516 link false /test okd-scos-e2e-aws-ovn-jenkins
ci/prow/e2e-aws-ovn-proxy 52a0516 link false /test e2e-aws-ovn-proxy
ci/prow/okd-scos-e2e-aws-ovn-upgrade 52a0516 link false /test okd-scos-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 52a0516 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-builds 52a0516 link false /test okd-e2e-aws-ovn-builds
ci/prow/okd-scos-e2e-aws-ovn-image-ecosystem 52a0516 link false /test okd-scos-e2e-aws-ovn-image-ecosystem
ci/prow/okd-scos-e2e-aws-operator 52a0516 link false /test okd-scos-e2e-aws-operator
ci/prow/e2e-aws 52a0516 link true /test e2e-aws
ci/prow/okd-scos-e2e-aws-ovn-builds 52a0516 link false /test okd-scos-e2e-aws-ovn-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filariow filariow filariow left review comments

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fbm3307 @openshift-ci-robot @openshift-bot @openshift-merge-robot @filariow