Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename clusteroperator resource, align manifests dir name w/ other operators #90

Merged
merged 1 commit into from
Feb 9, 2019
Merged

rename clusteroperator resource, align manifests dir name w/ other operators #90

merged 1 commit into from
Feb 9, 2019

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Feb 4, 2019 •
edited

fixes #96

@bparees
Copy link
Contributor Author

bparees commented Feb 4, 2019

/hold

/assign @gabemontero

this builds on top of your rhel enablement PR, so it should merge cleanly after yours merges, unless you have to make more changes to your PR.

@gabemontero
Copy link
Contributor

new commit looks good to me @bparees

@bparees bparees added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2019
@bparees
Copy link
Contributor Author

bparees commented Feb 4, 2019

/assign @gabemontero
(bot was dead)

@bparees
Copy link
Contributor Author

bparees commented Feb 4, 2019

/refresh

@bparees
Copy link
Contributor Author

bparees commented Feb 4, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 4, 2019
@bparees
Copy link
Contributor Author

bparees commented Feb 5, 2019

/test e2e-aws
/retest

@bparees
Copy link
Contributor Author

bparees commented Feb 5, 2019

unrelated failures
/retest

@bparees
Copy link
Contributor Author

bparees commented Feb 5, 2019

cluster-monitoring failed to go available
/test e2e-aws

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 6, 2019
@gabemontero
Copy link
Contributor

do we still want to hold this @bparees ?

@bparees
Copy link
Contributor Author

bparees commented Feb 7, 2019

i'd like to see it pass e2e-aws a few times so we know we're not introducing something that's going to block the install. Right now there's only one passing e2e-aws in the test history.

/refresh
/test e2e-aws

@bparees bparees closed this Feb 7, 2019
@bparees bparees reopened this Feb 7, 2019
@bparees
Copy link
Contributor Author

bparees commented Feb 7, 2019

/refresh

@bparees
Copy link
Contributor Author

bparees commented Feb 7, 2019

/test e2e-aws

4 similar comments
@bparees
Copy link
Contributor Author

bparees commented Feb 7, 2019

/test e2e-aws

@stevekuznetsov
Copy link
Contributor

/test e2e-aws

@stevekuznetsov
Copy link
Contributor

/test e2e-aws

@bparees
Copy link
Contributor Author

bparees commented Feb 7, 2019

/test e2e-aws

@bparees
Copy link
Contributor Author

bparees commented Feb 7, 2019

/hold cancel

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2019
@bparees bparees mentioned this pull request Feb 8, 2019
Closed
@bparees
Copy link
Contributor Author

bparees commented Feb 8, 2019

/retest

1 similar comment
@bparees
Copy link
Contributor Author

bparees commented Feb 8, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 4e687d9 into openshift:master Feb 9, 2019
@bparees bparees deleted the naming branch March 19, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename deploy directory to manifests
5 participants
@bparees @gabemontero @openshift-ci-robot @stevekuznetsov @openshift-merge-robot