Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1894025: Add annotations to cluster-csi-drivers namespace #100

Merged
merged 1 commit into from Nov 5, 2020
Merged

Bug 1894025: Add annotations to cluster-csi-drivers namespace #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions assets/csidriveroperators/aws-ebs/01_namespace.yaml
View file
Open in desktop
Expand Up @@ -2,3 +2,6 @@ apiVersion: v1
kind: Namespace
metadata:
name: openshift-cluster-csi-drivers
annotations:
include.release.openshift.io/self-managed-high-availability: "true"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is to match d558dbc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we could simply remove these files from assets because the openshift-cluster-csi-drivers namespace is created by CVO.

openshift.io/node-selector: ""
3 changes: 3 additions & 0 deletions assets/csidriveroperators/manila/01_namespace.yaml
View file
Open in desktop
Expand Up @@ -2,3 +2,6 @@ apiVersion: v1
kind: Namespace
metadata:
name: openshift-cluster-csi-drivers
annotations:
include.release.openshift.io/self-managed-high-availability: "true"
openshift.io/node-selector: ""
4 changes: 3 additions & 1 deletion assets/csidriveroperators/ovirt/01_namespace.yaml
View file
Open in desktop
@@ -1,5 +1,7 @@
---
apiVersion: v1
kind: Namespace
metadata:
name: openshift-cluster-csi-drivers
annotations:
include.release.openshift.io/self-managed-high-availability: "true"
openshift.io/node-selector: ""
1 change: 1 addition & 0 deletions manifests/02_csi_driver_operators_namespace.yaml
View file
Open in desktop
Expand Up @@ -4,3 +4,4 @@ metadata:
name: openshift-cluster-csi-drivers
annotations:
include.release.openshift.io/self-managed-high-availability: "true"
openshift.io/node-selector: ""
12 changes: 10 additions & 2 deletions pkg/generated/bindata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.