Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1902552: Fix cinder-csi images #104

Merged
merged 1 commit into from Nov 30, 2020
Merged

Bug 1902552: Fix cinder-csi images #104

merged 1 commit into from Nov 30, 2020

Conversation

mandre
Copy link
Member

@mandre mandre commented Nov 27, 2020 •
edited

The images were hardcoded to quay.io registries. They should instead be
templated to use values from the release payload.

Bindata generated with make update-bindata.

@mandre
Copy link
Member Author

mandre commented Nov 27, 2020

/cc Fedosin

Fedosin
Fedosin approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>_<
Sorry, my bad... These images are not used for real, we replace them when we build the release image. But yeah, there should not be any personal images, only those from openshift namespace.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2020
@mandre
Copy link
Member Author

mandre commented Nov 30, 2020

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@Fedosin
Copy link
Contributor

Fedosin commented Nov 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@mandre mandre changed the title Fix cinder-csi images Bug 1902552: Fix cinder-csi images Nov 30, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Bugzilla bug 1902552, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1902552: Fix cinder-csi images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Bugzilla bug 1902552, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1902552: Fix cinder-csi images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Bug 1902552: Template cinder-csi images
b4653c2 
The images were hardcoded to quay.io registries. They should instead be
templated to use values from the release payload.

Bindata generated with `make update-bindata`.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Bugzilla bug 1902552, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1902552: Fix cinder-csi images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member Author

mandre commented Nov 30, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Bugzilla bug 1902552, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 30, 2020
@jsafrane
Copy link
Contributor

/test e2e-openstack

1 similar comment
@mandre
Copy link
Member Author

mandre commented Nov 30, 2020

/test e2e-openstack

@mandre
Copy link
Member Author

mandre commented Nov 30, 2020

/retest

@mandre
Copy link
Member Author

mandre commented Nov 30, 2020

The platform running the openstack tests seems to be having a rough time.
/retest

@openshift-merge-robot
Copy link
Contributor

@mandre: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack b4653c2 link /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

/lgtm
I checked the logs, Cluster-storage-operator is installed together with Cinder CSI driver

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, jsafrane, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit bc8d42c into openshift:master Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: All pull requests linked via external trackers have merged:

Bugzilla bug 1902552 has been moved to the MODIFIED state.

In response to this:

Bug 1902552: Fix cinder-csi images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Fedosin approved these changes

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mandre @Fedosin @openshift-ci-robot @jsafrane @openshift-merge-robot