Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1914451: Run CSO as non-root user #123

Merged
merged 1 commit into from Jan 16, 2021
Merged

Bug 1914451: Run CSO as non-root user #123

merged 1 commit into from Jan 16, 2021

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jan 12, 2021 •
edited

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1914451

cc @sttts @openshift/storage

After the change:

~> oc exec cluster-storage-operator-77b4cffccb-bmtgb -i -t -- whoami
10400

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 12, 2021
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Bugzilla bug 1914451, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1914451: Run CSO as non-root user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2021
@gnufied
Copy link
Member Author

gnufied commented Jan 12, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 12, 2021
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Bugzilla bug 1914451, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 12, 2021
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Bugzilla bug 1914451, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1914451: Run CSO as non-root user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Jan 12, 2021

/retest

@gnufied
Copy link
Member Author

gnufied commented Jan 13, 2021

Tests are failing because of:

Jan 12 22:14:53.061: INFO: Fetching cloud provider for "gce"
I0112 22:14:53.061865   52354 gce.go:918] Using DefaultTokenSource &oauth2.reuseTokenSource{new:jwt.jwtSource{ctx:(*context.emptyCtx)(0xc0000820d0), conf:(*jwt.Config)(0xc00266f860)}, mu:sync.Mutex{state:0, sema:0x0}, t:(*oauth2.Token)(nil)}
W0112 22:14:53.137109   52354 gce.go:485] No network name or URL specified.
E0112 22:14:53.190499   52354 test_context.go:485] Failed to setup provider config for "gce": Error building GCE/GKE provider: unexpected response listing zones: googleapi: Error 403: Quota exceeded for quota group 'ListGroup' and limit 'List requests per 100 seconds' of service 'compute.googleapis.com' for consumer 'project_number:1053217076791'., rateLimitExceeded

/retest

@gnufied
Copy link
Member Author

gnufied commented Jan 13, 2021

/retest

@gnufied
Copy link
Member Author

gnufied commented Jan 13, 2021

/refresh

@openshift-ci-robot
Copy link
Contributor

@gnufied: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 58d42c0 link /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@huffmanca
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
tsmetana
tsmetana approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@tsmetana tsmetana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, huffmanca, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gnufied,huffmanca,tsmetana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnufied
Copy link
Member Author

gnufied commented Jan 15, 2021

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2021
@jsafrane
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 16, 2021
Merged
@openshift-merge-robot openshift-merge-robot merged commit 63201d7 into openshift:master Jan 16, 2021
@openshift-ci-robot
Copy link
Contributor

@gnufied: All pull requests linked via external trackers have merged:

Bugzilla bug 1914451 has been moved to the MODIFIED state.

In response to this:

Bug 1914451: Run CSO as non-root user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmetana tsmetana tsmetana approved these changes

@bertinatto bertinatto Awaiting requested review from bertinatto

Assignees

@tsmetana tsmetana

@huffmanca huffmanca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gnufied @openshift-ci-robot @huffmanca @jsafrane @openshift-bot @tsmetana @openshift-merge-robot