Support external control plane topology #187
Conversation
| @@ -41,6 +41,8 @@ type CSIOperatorConfig struct { | |||
| OLMOptions *OLMOptions | |||
| // Run the CSI driver operator only when given FeatureGate is enabled | |||
| RequireFeatureGate string | |||
| // Schedule CSI driver operator on workers when control plane is externalized | |||
| ScheduleOnWorkers bool | |||
There was a problem hiding this comment.
@csrwng on vSphere clusters we also schedule the vsphere-problem-detector pod on master nodes, is that something we need to change as well?
There was a problem hiding this comment.
Yes, thank you, we should. Will update this PR
|
Is there a generic document describing what runs where when using various deployment tools like installer (with masters), hypershift (without masters) etc? These PRs are nice, however, there are many things that need to be changed in all storage operators. |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
If running on a cluster with control plane topology of type 'External' (as in ROKS or Hypershift), CSI operators should not be scheduled to masters. This change sets the node selector to empty if this is the case.