Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1999674: Update prometheus rule to alert about esxi host versions #209

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 16 additions & 7 deletions assets/vsphere_problem_detector/12_prometheusrules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,26 @@ spec:
- alert: CSIWithOldVSphereHWVersion
# Using min_over_time to make sure the metric is `1` for whole 5 minutes.
# A missed scraping (e.g. due to a pod restart) will result in prometheus re-evaluating the the alerting rule.
# Using ON() to have logical "and" with unrelated labels.
expr: |
min_over_time(vsphere_node_hw_version_total{hw_version=~"vmx-(11|12|13|14)"}[5m]) > 0
and ON()
count(cluster_feature_set{name="TechPreviewNoUpgrade"}) > 0
for: 10m
labels:
severity: info
annotations:
summary: "Detected vSphere VM with HW version lower than 15, which is not supported by the installed vSphere CSI driver."
summary: "Detected vSphere VM with HW version lower than 15, which is being deprecated by Openshift."
description: |
The cluster runs the vSphere CSI driver (it has TechPreviewNoUpgrade features enabled) and the CSI driver does not
support vSphere VMs with HW version lower than 15. Please update HW version of all VMs that are part of the cluster
to at least HW version 15.
The cluster is using VMs with hardware version lower than 15, which is being deprecated by Openshift. Hardware version 15 or greater
is required by vSphere CSI driver. Please update your VMs to at least HW version 15.
- alert: VSphereOlderVersionPresent
# Using min_over_time to make sure the metric is `1` for whole 5 minutes.
# A missed scraping (e.g. due to a pod restart) will result in prometheus re-evaluating the the alerting rule.
expr: |
min_over_time(vsphere_esxi_version_total{api_version!~"6.7.3|7.*"}[5m]) > 0
for: 10m
labels:
severity: info
annotations:
summary: "Detected vSphere host with ESXi version less than 6.7u3 in Openshift cluster."
description: |
The cluster is using ESXi hosts which are on version less than 6.7u3, which is being deprecated by Openshift. A future version of
Openshift will remove support for ESXi version less than 6.7u3 and it is recommended to update your hosts to latest ESXi version.
1 change: 1 addition & 0 deletions pkg/dependencymagnet/dependencymagnet.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build tools
// +build tools

// go mod won't pull in code that isn't depended upon, but we have some code we don't depend on from code that must be included
Expand Down