Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azure default storageclass #28

Merged
merged 1 commit into from Apr 23, 2019
Merged

Add azure default storageclass #28

merged 1 commit into from Apr 23, 2019

Conversation

juan-lee
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2019
@juan-lee
Copy link
Contributor Author

/retest

wongma7
wongma7 reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@wongma7 wongma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for PR, have some questions.

assets/azure.yaml Outdated Show resolved Hide resolved
assets/azure.yaml
reclaimPolicy: Retain
parameters:
kind: Managed
storageaccounttype: Premium_LRS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the VM is standard or unmanaged? Ideally the default "standard" class won't have any parameters set, so that it works with every cluster, like https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/storage-class/azure/default.yaml. Can we safely assume that openshift will only be installed on clusters where VMs are premium+managed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wongma7 Azure's managed disk offering works with all of our VMs and is our recommended default. Standard storageaccounttype is meant for testing/entry level prod workloads where Premium is what we recommend for our customers for production use. I also checked and managed-premium is the closest equivalent to the aws default storage class.

@wongma7
Copy link
Contributor

wongma7 commented Apr 23, 2019

/lgtm

thanks

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juan-lee, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4f68118 into openshift:master Apr 23, 2019
gnufied pushed a commit to gnufied/cluster-storage-operator that referenced this pull request Dec 4, 2019
@openshift-merge-robot
Merge pull request openshift#28 from njhale/simplify-apis
0e06c9d 
Simplify OLM APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 wongma7 left review comments

@gnufied gnufied Awaiting requested review from gnufied

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juan-lee @wongma7 @openshift-ci-robot @openshift-merge-robot