Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2084219: Fix RelatedObjects when an API is missing in the API server #281

Merged
merged 1 commit into from May 31, 2022
Merged

Bug 2084219: Fix RelatedObjects when an API is missing in the API server #281

merged 1 commit into from May 31, 2022

Conversation

bertinatto
Copy link
Member

This is a 4.9 backport of #215:

When starting a CSI driver operator and discovering its dependencies / RelatedObjects, some APIs may be temporarily missing in the API server.

RESTMapper is caching the error responses, so make sure to refresh the cache in the next sync.

CC @openshift/storage

@jsafrane @bertinatto
Fix RelatedObjects when an API is missing in the API server
6d308c7 
When starting a CSI driver operator and discovering its dependencies /
RelatedObjects, some APIs may be temporarily missing in the API server.
RESTMapper is caching the error responses, so make sure to refresh the
cache in the next sync.
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@bertinatto: This pull request references Bugzilla bug 2078625, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2078625: Fix RelatedObjects when an API is missing in the API server

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto bertinatto changed the base branch from master to release-4.9 May 11, 2022 13:52
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@bertinatto: This pull request references Bugzilla bug 2078625, which is invalid:

  • expected Bugzilla bug 2078625 to depend on a bug targeting a release in 4.10.0, 4.10.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2078625: Fix RelatedObjects when an API is missing in the API server

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana May 11, 2022 13:52
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@bertinatto bertinatto changed the title Bug 2078625: Fix RelatedObjects when an API is missing in the API server Bug 2084219: Fix RelatedObjects when an API is missing in the API server May 11, 2022
@bertinatto
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@bertinatto: This pull request references Bugzilla bug 2084219, which is invalid:

  • expected the bug to target the "4.9.z" release, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2084219: Fix RelatedObjects when an API is missing in the API server

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@bertinatto: This pull request references Bugzilla bug 2084219, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2001761 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2001761 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@bertinatto: This pull request references Bugzilla bug 2084219, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2001761 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2001761 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member Author

/retest

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2022
@bertinatto
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 13, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@bertinatto
Copy link
Member Author

/hold
until openshift/release#28621 is merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2022
@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/hold cancel
openshift/release#28621 is merged

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2022 •
edited

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 6d308c7 link true /test images
ci/prow/verify 6d308c7 link true /test verify
ci/prow/unit 6d308c7 link true /test unit
ci/prow/e2e-vsphere 6d308c7 link false /test e2e-vsphere
ci/prow/e2e-gcp 6d308c7 link true /test e2e-gcp
ci/prow/e2e-aws-upgrade 6d308c7 link true /test e2e-aws-upgrade
ci/prow/e2e-aws 6d308c7 link true /test e2e-aws
ci/prow/e2e-azure 6d308c7 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member Author

/hold cancel openshift/release#28621 is merged

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2022
@bertinatto
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jsafrane
Copy link
Contributor

/refresh

@jsafrane
Copy link
Contributor

/retest

1 similar comment
@bertinatto
Copy link
Member Author

/retest

@jsafrane
Copy link
Contributor

I don't get it. e2e-azure-file-csi is optional, yet tide wants it green.
/retest

@jsafrane
Copy link
Contributor

/test e2e-azure-file-csi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@jsafrane: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-aws-upgrade
  • /test e2e-gcp
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-csi
  • /test e2e-azure
  • /test e2e-azure-csi
  • /test e2e-gcp-csi
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test e2e-vsphere-csi

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-storage-operator-release-4.9-e2e-aws
  • pull-ci-openshift-cluster-storage-operator-release-4.9-e2e-aws-upgrade
  • pull-ci-openshift-cluster-storage-operator-release-4.9-e2e-azure
  • pull-ci-openshift-cluster-storage-operator-release-4.9-e2e-azure-csi
  • pull-ci-openshift-cluster-storage-operator-release-4.9-e2e-gcp
  • pull-ci-openshift-cluster-storage-operator-release-4.9-e2e-ovirt
  • pull-ci-openshift-cluster-storage-operator-release-4.9-e2e-vsphere
  • pull-ci-openshift-cluster-storage-operator-release-4.9-e2e-vsphere-csi
  • pull-ci-openshift-cluster-storage-operator-release-4.9-images
  • pull-ci-openshift-cluster-storage-operator-release-4.9-unit
  • pull-ci-openshift-cluster-storage-operator-release-4.9-verify

In response to this:

/test e2e-azure-file-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor

/test e2e-azure-csi

@jsafrane
Copy link
Contributor

There is no e2e-azure-file-csi job!
/override ci/prow/e2e-vsphere-csi

@jsafrane
Copy link
Contributor

/override ci/prow/e2e-azure-file-csi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/e2e-vsphere-csi

In response to this:

There is no e2e-azure-file-csi job!
/override ci/prow/e2e-vsphere-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/e2e-azure-file-csi

In response to this:

/override ci/prow/e2e-azure-file-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 41bcd65 into openshift:release-4.9 May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@bertinatto: All pull requests linked via external trackers have merged:

Bugzilla bug 2084219 has been moved to the MODIFIED state.

In response to this:

Bug 2084219: Fix RelatedObjects when an API is missing in the API server

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@jsafrane jsafrane

@jhou1 jhou1

@chao007 chao007

@duanwei33 duanwei33

@ropatil010 ropatil010

@Phaow Phaow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bertinatto @jsafrane @openshift-bot @Phaow @jhou1 @chao007 @openshift-merge-robot @duanwei33 @ropatil010