New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCO-324,CCO-325: pass version to azure operators #372
CCO-324,CCO-325: pass version to azure operators #372
Conversation
- name: OPERATOR_IMAGE_VERSION | ||
value: ${OPERATOR_IMAGE_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not get replaced automatically, you still need to provide the replacement around
cluster-storage-operator/pkg/operator/csidriveroperator/csioperatorclient/azure-disk.go
Lines 18 to 22 in d91b59b
pairs := []string{ | |
"${OPERATOR_IMAGE}", os.Getenv(envAzureDiskDriverOperatorImage), | |
"${DRIVER_IMAGE}", os.Getenv(envAzureDiskDriverImage), | |
"${CLUSTER_CLOUD_CONTROLLER_MANAGER_OPERATOR_IMAGE}", os.Getenv(envCCMOperatorImage), | |
} |
Same for azure-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, done.
ea28b90
to
65b9503
Compare
/retest |
488bbf0
to
9dd8698
Compare
This is required by the new way of handling featuregates.
9dd8698
to
b43c7c9
Compare
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@RomanBednar: This pull request references CCO-325 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @openshift/storage for review |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@RomanBednar: This pull request references CCO-324 which is a valid jira issue. This pull request references CCO-325 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3198372
into
openshift:master
Required for feature gates openshift/azure-disk-csi-driver-operator#78