Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCO-324,CCO-325: pass version to azure operators #372

Merged
merged 2 commits into from Jun 19, 2023

Conversation

RomanBednar
Copy link
Contributor

Required for feature gates openshift/azure-disk-csi-driver-operator#78

Comment on lines +44 to +45
- name: OPERATOR_IMAGE_VERSION
value: ${OPERATOR_IMAGE_VERSION}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not get replaced automatically, you still need to provide the replacement around

pairs := []string{
"${OPERATOR_IMAGE}", os.Getenv(envAzureDiskDriverOperatorImage),
"${DRIVER_IMAGE}", os.Getenv(envAzureDiskDriverImage),
"${CLUSTER_CLOUD_CONTROLLER_MANAGER_OPERATOR_IMAGE}", os.Getenv(envCCMOperatorImage),
}

Same for azure-file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, done.

@RomanBednar
Copy link
Contributor Author

/retest

This is required by the new way of handling featuregates.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2023

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-ovn-conformance ea28b90 link false /test e2e-hypershift-ovn-conformance
ci/prow/e2e-azure-csi b43c7c9 link false /test e2e-azure-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RomanBednar RomanBednar changed the title pass version to azure operators CCO-324 CCO-325: pass version to azure operators Jun 5, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 5, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 5, 2023

@RomanBednar: This pull request references CCO-325 which is a valid jira issue.

In response to this:

Required for feature gates openshift/azure-disk-csi-driver-operator#78

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RomanBednar
Copy link
Contributor Author

cc @openshift/storage for review

@jsafrane
Copy link
Contributor

jsafrane commented Jun 6, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@RomanBednar RomanBednar changed the title CCO-324 CCO-325: pass version to azure operators CCO-324,CCO-325: pass version to azure operators Jun 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 15, 2023

@RomanBednar: This pull request references CCO-324 which is a valid jira issue.

This pull request references CCO-325 which is a valid jira issue.

In response to this:

Required for feature gates openshift/azure-disk-csi-driver-operator#78

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cf2524d and 2 for PR HEAD b43c7c9 in total

@openshift-merge-robot openshift-merge-robot merged commit 3198372 into openshift:master Jun 19, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants