Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-11359: Remove unused versions from status #374

Merged
merged 1 commit into from Jul 31, 2023

Conversation

jsafrane
Copy link
Contributor

Remove all unknown version from storage's ClusterOperator.Status.

This will clean AWSEBSCSIDriverOperator entry introduced in 4.8.

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 30, 2023
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Jira Issue OCPBUGS-11359, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Remove all unknown version from storage's ClusterOperator.Status.

This will clean AWSEBSCSIDriverOperator entry introduced in 4.8.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 30, 2023
@openshift-ci-robot
Copy link
Contributor

@jsafrane: This pull request references Jira Issue OCPBUGS-11359, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dobsonj and gnufied May 30, 2023 08:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2023
@jsafrane
Copy link
Contributor Author

/hold
it needs #368 merged again (it got reverted)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@jsafrane
Copy link
Contributor Author

/hold cancel

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023
@jsafrane
Copy link
Contributor Author

/retest

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1611e65 and 2 for PR HEAD 1eb69c1 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b5cfc04 and 1 for PR HEAD 1eb69c1 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@jsafrane
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Contributor Author

/retest-required

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 83feb2f and 2 for PR HEAD 3dad1aa in total

@mpatlasov
Copy link
Contributor

/test e2e-aws-ovn

Prow job (https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-storage-operator/374/pull-ci-openshift-cluster-storage-operator-master-e2e-aws-ovn/1684917025169739776) reads:

: [sig-autoscaling] [Feature:HPA] Horizontal pod autoscaling (scale resource: CPU) CustomResourceDefinition Should scale with a CRD targetRef [Suite:openshift/conformance/parallel] [Suite:k8s] expand_less
--
Run #0: Failed expand_less5m45s{  fail [test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Error: exit with code 1 Ginkgo exit error 1: exit with code 1}open stdoutopen_in_newRun #1: Failed expand_less5m42s{  fail [k8s.io/kubernetes@v1.27.1/test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Ginkgo exit error 1: exit with code 1} | Run #0: Failed expand_less5m45s{  fail [test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Error: exit with code 1 Ginkgo exit error 1: exit with code 1}open stdoutopen_in_new | Run #0: Failed expand_less | 5m45s | {  fail [test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Error: exit with code 1 Ginkgo exit error 1: exit with code 1}open stdoutopen_in_new | Run #1: Failed expand_less5m42s{  fail [k8s.io/kubernetes@v1.27.1/test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Ginkgo exit error 1: exit with code 1} | Run #1: Failed expand_less | 5m42s | {  fail [k8s.io/kubernetes@v1.27.1/test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Ginkgo exit error 1: exit with code 1}
Run #0: Failed expand_less5m45s{  fail [test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Error: exit with code 1 Ginkgo exit error 1: exit with code 1}open stdoutopen_in_new | Run #0: Failed expand_less | 5m45s | {  fail [test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Error: exit with code 1 Ginkgo exit error 1: exit with code 1}open stdoutopen_in_new
Run #0: Failed expand_less | 5m45s
{  fail [test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Error: exit with code 1 Ginkgo exit error 1: exit with code 1}open stdoutopen_in_new
Run #1: Failed expand_less5m42s{  fail [k8s.io/kubernetes@v1.27.1/test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Ginkgo exit error 1: exit with code 1} | Run #1: Failed expand_less | 5m42s | {  fail [k8s.io/kubernetes@v1.27.1/test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Ginkgo exit error 1: exit with code 1}
Run #1: Failed expand_less | 5m42s
{  fail [k8s.io/kubernetes@v1.27.1/test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition Ginkgo exit error 1: exit with code 1}

: [sig-autoscaling] [Feature:HPA] Horizontal pod autoscaling (scale resource: CPU) CustomResourceDefinition Should scale with a CRD targetRef [Suite:openshift/conformance/parallel] [Suite:k8s] expand_less
Run #0: Failed expand_less	5m45s
{  fail [test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition
Error: exit with code 1
Ginkgo exit error 1: exit with code 1}
[open stdoutopen_in_new](https://prow.ci.openshift.org/spyglass/lens/junit/iframe?req=%7B%22artifacts%22%3A%5B%22artifacts%2Fe2e-aws-ovn%2Fgather-extra%2Fartifacts%2Fjunit%2Fjunit_install_status.xml%22%2C%22artifacts%2Fe2e-aws-ovn%2Fgather-extra%2Fartifacts%2Fjunit%2Fjunit_symptoms.xml%22%2C%22artifacts%2Fe2e-aws-ovn%2Fgather-must-gather%2Fartifacts%2Fjunit_install.xml%22%2C%22artifacts%2Fe2e-aws-ovn%2Fopenshift-e2e-test%2Fartifacts%2Fjunit%2Fjunit_e2e__20230728-140515.xml%22%2C%22artifacts%2Fe2e-aws-ovn%2Fopenshift-e2e-test%2Fartifacts%2Fjunit_node_ready.xml%22%2C%22artifacts%2Fe2e-aws-ovn%2Fopenshift-e2e-test%2Fartifacts%2Fjunit_nodes.xml%22%2C%22artifacts%2Fjunit_operator.xml%22%5D%2C%22index%22%3A2%2C%22src%22%3A%22gs%2Forigin-ci-test%2Fpr-logs%2Fpull%2Fopenshift_cluster-storage-operator%2F374%2Fpull-ci-openshift-cluster-storage-operator-master-e2e-aws-ovn%2F1684917025169739776%22%7D&topURL=https%3A//prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-storage-operator/374/pull-ci-openshift-cluster-storage-operator-master-e2e-aws-ovn/1684917025169739776&lensIndex=2#)
Run #1: Failed expand_less	5m42s
{  fail [k8s.io/kubernetes@v1.27.1/test/e2e/framework/autoscaling/autoscaling_utils.go:378]: timed out waiting for the condition
Ginkgo exit error 1: exit with code 1}

I can't believe it's relevant to PR, let's re-test...

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-ovn-conformance f5a41a4 link false /test e2e-hypershift-ovn-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit b547dfb into openshift:master Jul 31, 2023
14 checks passed
@openshift-ci-robot
Copy link
Contributor

@jsafrane: Jira Issue OCPBUGS-11359: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11359 has been moved to the MODIFIED state.

In response to this:

Remove all unknown version from storage's ClusterOperator.Status.

This will clean AWSEBSCSIDriverOperator entry introduced in 4.8.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants